Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can I explicitly ignore a field? #71

Closed
mjpitz opened this issue Nov 19, 2020 · 9 comments
Closed

Can I explicitly ignore a field? #71

mjpitz opened this issue Nov 19, 2020 · 9 comments
Labels
enhancement New feature or request

Comments

@mjpitz
Copy link

mjpitz commented Nov 19, 2020

There are a few fields I don't want to show up in my README. Is there a way to explicitly ignore or exclude a field?

@norwoodj
Copy link
Owner

There is not at present, but I think this is a reasonable ask. I can envision a flag (that can be repeated) like --skip-values deployment.replicas or similar. I can implement this when I get more time, (I'm very busy with my real job at present). Please feel free to submit a PR though.

@mjpitz
Copy link
Author

mjpitz commented Nov 21, 2020

No worries! I'll try and pull something together when I have a minute. Just wanted to make sure I wasn't missing something.

@Pothulapati
Copy link

👍 on this feature request! Would be useful for my use-case too!

@norwoodj norwoodj added the enhancement New feature or request label Jan 12, 2021
@keyvaann
Copy link

keyvaann commented Aug 2, 2021

Would be good if this was implemented the same way as Bitnami's readme-generator-for-helm that you can specify fields to skip in the values.yaml itself.
https://github.com/bitnami-labs/readme-generator-for-helm#metadata

This would scale better when generating docs for multiple charts compared to using --skip-values flag.

@sheisnicola
Copy link

@K1Hyve @Pothulapati @mjpitz I needed something similar to this as well, but was able to implement it by generating the table myself in a custom template (I provide an example in an unrelated enhancement request I just raised here #107).

@j-buczak
Copy link
Contributor

PR for this: Add option for ignoring values #141

@Anticom
Copy link

Anticom commented Jul 7, 2022

There is not at present, but I think this is a reasonable ask. I can envision a flag (that can be repeated) like --skip-values deployment.replicas or similar. I can implement this when I get more time, (I'm very busy with my real job at present). Please feel free to submit a PR though.

I'd prefer configuring which values to skip via a special doc comment directive rather than a flag for helm-docs cli. My reasoning / use case is setting some values on sub chart's values. Since those are (hopefully) documented in the referenced chart, it would be superflous to have documentation for those overrides generated in my chart.

Alternatively the --skip-values flag either would have to work recursively or it would have to support globbing patterns. Otherwise I'd have to specify a huge set of values to be ignored / skipped.

@j-buczak
Copy link
Contributor

j-buczak commented Jul 8, 2022

@Anticom doc directive is already merged. It's documented here: https://github.com/norwoodj/helm-docs#ignoring-values

I don't know what are the plans for --skip-values flag. I can envision a case when it's useful, but I don't know what are the plans for this.

@norwoodj As the original question/feature request is resolved, I would close this issue.

@Anticom
Copy link

Anticom commented Jul 8, 2022

doc directive is already merged. It's documented here: https://github.com/norwoodj/helm-docs#ignoring-values

Oh, I've totally missed that. Thanks for the heads-up! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

7 participants