fix: handle consumption of aborted request

Author: metcoder95

lib/client.js

@@ -1805,6 +1805,11 @@ function writeH2 (client, session, request) {
   })
 
   stream.on('data', (chunk) => {
+    // Aborting a request does not abort
+    // the stream, so we need to check and destroy it if request
+    // is aborted.
+    if (request.aborted) util.destroy(stream, new RequestAbortedError())
+
     if (request.onData(chunk) === false) stream.pause()
   })
 

test/fetch/http2.js

@@ -413,3 +413,64 @@ test('Issue#2415', async (t) => {
 
   t.doesNotThrow(() => new Headers(response.headers))
 })
+
+test('Issue #2386', async t => {
+  const server = createSecureServer(pem)
+  const body = Buffer.from('hello')
+  const requestChunks = []
+  const expectedResponseBody = { hello: 'h2' }
+  const controller = new AbortController()
+  const signal = controller.signal
+
+  server.on('stream', async (stream, headers) => {
+    t.equal(headers[':method'], 'PUT')
+    t.equal(headers[':path'], '/')
+    t.equal(headers[':scheme'], 'https')
+
+    stream.on('data', chunk => requestChunks.push(chunk))
+
+    stream.respond({
+      'content-type': 'application/json',
+      'x-custom-h2': headers['x-my-header'],
+      ':status': 200
+    })
+
+    stream.end(JSON.stringify(expectedResponseBody))
+  })
+
+  t.plan(3)
+
+  server.listen(0)
+  await once(server, 'listening')
+
+  const client = new Client(`https://localhost:${server.address().port}`, {
+    connect: {
+      rejectUnauthorized: false
+    },
+    allowH2: true
+  })
+
+  t.teardown(server.close.bind(server))
+  t.teardown(client.close.bind(client))
+
+  try {
+    await fetch(
+      `https://localhost:${server.address().port}/`,
+      // Needs to be passed to disable the reject unauthorized
+      {
+        body,
+        signal,
+        method: 'PUT',
+        dispatcher: client,
+        headers: {
+          'x-my-header': 'foo',
+          'content-type': 'text-plain'
+        }
+      }
+    )
+
+    controller.abort()
+  } catch (error) {
+    t.error(error)
+  }
+})