Skip to content

Commit 77a7947

Browse files
authored
expose WebSocket related events in node bundle (#3167)
Refs: nodejs/node#50275
1 parent d3de002 commit 77a7947

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

index-fetch.js

+4-1
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,11 @@ module.exports.Headers = require('./lib/web/fetch/headers').Headers
1717
module.exports.Response = require('./lib/web/fetch/response').Response
1818
module.exports.Request = require('./lib/web/fetch/request').Request
1919

20+
const { CloseEvent, ErrorEvent, MessageEvent } = require('./lib/web/websocket/events')
2021
module.exports.WebSocket = require('./lib/web/websocket/websocket').WebSocket
21-
module.exports.MessageEvent = require('./lib/web/websocket/events').MessageEvent
22+
module.exports.CloseEvent = CloseEvent
23+
module.exports.ErrorEvent = ErrorEvent
24+
module.exports.MessageEvent = MessageEvent
2225

2326
module.exports.EventSource = require('./lib/web/eventsource/eventsource').EventSource
2427

test/fetch/bundle.js

+7-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
const { test } = require('node:test')
44
const assert = require('node:assert')
55

6-
const { Response, Request, FormData, Headers } = require('../../undici-fetch')
6+
const { Response, Request, FormData, Headers, MessageEvent, CloseEvent, ErrorEvent } = require('../../undici-fetch')
77

88
test('bundle sets constructor.name and .name properly', () => {
99
assert.strictEqual(new Response().constructor.name, 'Response')
@@ -31,3 +31,9 @@ test('regression test for https://github.com/nodejs/node/issues/50263', () => {
3131

3232
assert.strictEqual(request1.headers.get('test'), 'abc')
3333
})
34+
35+
test('WebSocket related events are exported', (t) => {
36+
assert.deepStrictEqual(typeof CloseEvent, 'function')
37+
assert.deepStrictEqual(typeof MessageEvent, 'function')
38+
assert.deepStrictEqual(typeof ErrorEvent, 'function')
39+
})

0 commit comments

Comments
 (0)