Skip to content

Commit 0a64b44

Browse files
authored
fetch: fix captureStackTrace (#3227)
* fetch: fix captureStackTrace * improve test case performance
1 parent a613753 commit 0a64b44

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

index-fetch.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const fetchImpl = require('./lib/web/fetch').fetch
77
module.exports.fetch = function fetch (resource, init = undefined) {
88
return fetchImpl(resource, init).catch((err) => {
99
if (err && typeof err === 'object') {
10-
Error.captureStackTrace(err, this)
10+
Error.captureStackTrace(err)
1111
}
1212
throw err
1313
})

index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ module.exports.fetch = async function fetch (init, options = undefined) {
108108
return await fetchImpl(init, options)
109109
} catch (err) {
110110
if (err && typeof err === 'object') {
111-
Error.captureStackTrace(err, this)
111+
Error.captureStackTrace(err)
112112
}
113113

114114
throw err

test/fetch/client-error-stack-trace.js

+6-1
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,14 @@
22

33
const { test } = require('node:test')
44
const assert = require('node:assert')
5-
const { fetch } = require('../..')
5+
const { fetch, setGlobalDispatcher, Agent } = require('../..')
66
const { fetch: fetchIndex } = require('../../index-fetch')
77

8+
setGlobalDispatcher(new Agent({
9+
headersTimeout: 500,
10+
connectTimeout: 500
11+
}))
12+
813
test('FETCH: request errors and prints trimmed stack trace', async (t) => {
914
try {
1015
await fetch('http://a.com')

0 commit comments

Comments
 (0)