server.close() callback error argument is undefined

[armanbilge]

Version

v19.8.1

Platform

Linux armanbilge-sandbox-d5bpibghud0 5.15.0-47-generic #51-Ubuntu SMP Thu Aug 11 07:51:15 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

const net = require("net")
const server = net.createServer()
server.listen()
server.close(x => console.log(typeof(x)))

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior? Why is that the expected behavior?

Following discussion in #44290 (comment) and #47229 (comment), to be consistent with other Node.js APIs null should be used to indicate there is no error.

What do you see instead?

$ npx node@19 test.js 
undefined

Additional information

No response

[mk-pmb]

I don't see a bug here. Robustness principle at work. (More details in #47229 )

[jswalden]

I kicked off the process of getting the TypeScript bindings changed to use err?: Error | null rather than err?: Error to align with reality here. DefinitelyTyped/DefinitelyTyped#72657

[jswalden]

Oh, I misread, this isn't supplying null here, never mind. Binding types ain't gonna change until that change, I'd fully expect.