Skip to content

Commit f2cc28a

Browse files
addaleaxmmarchini
authored andcommitted
test: use InitializeNodeWithArgs in cctest
Refs: d7f1107 Fixes: #30257 PR-URL: #32406 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 6b5f82d commit f2cc28a

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

test/cctest/node_test_fixture.h

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,13 @@ class NodeZeroIsolateTestFixture : public ::testing::Test {
7272
if (!node_initialized) {
7373
uv_os_unsetenv("NODE_OPTIONS");
7474
node_initialized = true;
75-
int argc = 1;
76-
const char* argv0 = "cctest";
77-
int exec_argc;
78-
const char** exec_argv;
79-
node::Init(&argc, &argv0, &exec_argc, &exec_argv);
75+
std::vector<std::string> argv { "cctest" };
76+
std::vector<std::string> exec_argv;
77+
std::vector<std::string> errors;
78+
79+
int exitcode = node::InitializeNodeWithArgs(&argv, &exec_argv, &errors);
80+
CHECK_EQ(exitcode, 0);
81+
CHECK(errors.empty());
8082
}
8183

8284
tracing_agent = std::make_unique<node::tracing::Agent>();

0 commit comments

Comments
 (0)