Skip to content

Commit f24aa7e

Browse files
gonendukMylesBorins
authored andcommitted
test: improve error messages in test-npm-install
PR-URL: #11027 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
1 parent 1db89d4 commit f24aa7e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/parallel/test-npm-install.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ const proc = spawn(process.execPath, args, {
4848
});
4949

5050
function handleExit(code, signalCode) {
51-
assert.equal(code, 0, 'npm install should run without an error');
52-
assert.ok(signalCode === null, 'signalCode should be null');
51+
assert.strictEqual(code, 0, `npm install got error code ${code}`);
52+
assert.strictEqual(signalCode, null, `unexpected signal: ${signalCode}`);
5353
assert.doesNotThrow(function() {
5454
fs.accessSync(installDir + '/node_modules/package-name');
5555
});

0 commit comments

Comments
 (0)