Skip to content

Commit f17f473

Browse files
committed
build: rename binary from node to iojs
* rename the build targets * update the test runner to use `out/{Debug,Release}/iojs` * update the installer to install the iojs binary * update one test that explicitly checks for the binary name PR-URL: #262 Reviewed-By: Bert Belder <[email protected]>
1 parent 3e7a25d commit f17f473

File tree

6 files changed

+25
-25
lines changed

6 files changed

+25
-25
lines changed

.gitignore

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ tags
1010
doc/api.xml
1111
tmp/
1212
test/tmp*/
13-
node
14-
node_g
13+
iojs
14+
iojs_g
1515
*.swp
1616
.benchmark_reports
1717
/.project

Makefile

+11-11
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ PREFIX ?= /usr/local
1111
EXEEXT := $(shell $(PYTHON) -c \
1212
"import sys; print('.exe' if sys.platform == 'win32' else '')")
1313

14-
NODE ?= ./node$(EXEEXT)
15-
NODE_EXE = node$(EXEEXT)
16-
NODE_G_EXE = node_g$(EXEEXT)
14+
NODE ?= ./iojs$(EXEEXT)
15+
NODE_EXE = iojs$(EXEEXT)
16+
NODE_G_EXE = iojs_g$(EXEEXT)
1717

1818
# Default to verbose builds.
1919
# To do quiet/pretty builds, run `make V=` to set V to an empty string,
@@ -240,20 +240,20 @@ else
240240
ARCH=x86
241241
endif
242242
endif
243-
TARNAME=node-$(VERSION)
243+
TARNAME=iojs-$(VERSION)
244244
ifdef NIGHTLY
245245
TAG = nightly-$(NIGHTLY)
246-
TARNAME=node-$(VERSION)-$(TAG)
246+
TARNAME=iojs-$(VERSION)-$(TAG)
247247
endif
248248
TARBALL=$(TARNAME).tar.gz
249249
BINARYNAME=$(TARNAME)-$(PLATFORM)-$(ARCH)
250250
BINARYTAR=$(BINARYNAME).tar.gz
251251
PKG=out/$(TARNAME).pkg
252252
packagemaker=/Developer/Applications/Utilities/PackageMaker.app/Contents/MacOS/PackageMaker
253253

254-
PKGSRC=nodejs-$(DESTCPU)-$(RAWVER).tgz
254+
PKGSRC=iojs-$(DESTCPU)-$(RAWVER).tgz
255255
ifdef NIGHTLY
256-
PKGSRC=nodejs-$(DESTCPU)-$(RAWVER)-$(TAG).tgz
256+
PKGSRC=iojs-$(DESTCPU)-$(RAWVER)-$(TAG).tgz
257257
endif
258258

259259
dist: doc $(TARBALL) $(PKG)
@@ -293,11 +293,11 @@ $(PKG): release-only
293293
$(PYTHON) ./configure --without-snapshot --dest-cpu=x64 --tag=$(TAG)
294294
$(MAKE) install V=$(V) DESTDIR=$(PKGDIR)
295295
SIGN="$(APP_SIGN)" PKGDIR="$(PKGDIR)" bash tools/osx-codesign.sh
296-
lipo $(PKGDIR)/32/usr/local/bin/node \
297-
$(PKGDIR)/usr/local/bin/node \
298-
-output $(PKGDIR)/usr/local/bin/node-universal \
296+
lipo $(PKGDIR)/32/usr/local/bin/iojs \
297+
$(PKGDIR)/usr/local/bin/iojs \
298+
-output $(PKGDIR)/usr/local/bin/iojs-universal \
299299
-create
300-
mv $(PKGDIR)/usr/local/bin/node-universal $(PKGDIR)/usr/local/bin/node
300+
mv $(PKGDIR)/usr/local/bin/iojs-universal $(PKGDIR)/usr/local/bin/iojs
301301
rm -rf $(PKGDIR)/32
302302
$(packagemaker) \
303303
--id "org.nodejs.Node" \

node.gyp

+1-1
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@
7373

7474
'targets': [
7575
{
76-
'target_name': 'node',
76+
'target_name': 'iojs',
7777
'type': 'executable',
7878

7979
'dependencies': [

test/parallel/test-process-argv-0.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ console.error('argv=%j', process.argv);
2828
console.error('exec=%j', process.execPath);
2929

3030
if (process.argv[2] !== "child") {
31-
var child = spawn('./node', [__filename, "child"], {
31+
var child = spawn('./iojs', [__filename, "child"], {
3232
cwd: path.dirname(process.execPath)
3333
});
3434

@@ -44,7 +44,7 @@ if (process.argv[2] !== "child") {
4444
console.error('CHILD: %s', childErr.trim().split('\n').join('\nCHILD: '));
4545
if (process.platform === 'win32') {
4646
// On Windows argv[0] is not expanded into full path
47-
assert.equal(childArgv0, './node');
47+
assert.equal(childArgv0, './iojs');
4848
} else {
4949
assert.equal(childArgv0, process.execPath);
5050
}

tools/install.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -108,12 +108,12 @@ def npm_files(action):
108108
if os.environ.get('PORTABLE'):
109109
# This crazy hack is necessary to make the shebang execute the copy
110110
# of node relative to the same directory as the npm script. The precompiled
111-
# binary tarballs use a prefix of "/" which gets translated to "/bin/node"
111+
# binary tarballs use a prefix of "/" which gets translated to "/bin/iojs"
112112
# in the regular shebang modifying logic, which is incorrect since the
113113
# precompiled bundle should be able to be extracted anywhere and "just work"
114-
shebang = '/bin/sh\n// 2>/dev/null; exec "`dirname "$0"`/node" "$0" "$@"'
114+
shebang = '/bin/sh\n// 2>/dev/null; exec "`dirname "$0"`/iojs" "$0" "$@"'
115115
else:
116-
shebang = os.path.join(node_prefix or '/', 'bin/node')
116+
shebang = os.path.join(node_prefix or '/', 'bin/iojs')
117117
update_shebang(link_path, shebang)
118118
else:
119119
assert(0) # unhandled action type
@@ -128,7 +128,7 @@ def subdir_files(path, dest, action):
128128

129129
def files(action):
130130
exeext = '.exe' if sys.platform == 'win32' else ''
131-
action(['out/Release/node' + exeext], 'bin/node' + exeext)
131+
action(['out/Release/iojs' + exeext], 'bin/iojs' + exeext)
132132

133133
if 'true' == variables.get('node_use_dtrace'):
134134
action(['out/Release/node.d'], 'lib/dtrace/node.d')

tools/test.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -742,20 +742,20 @@ def __init__(self, workspace, buildspace, verbose, vm, timeout, processor, suppr
742742

743743
def GetVm(self, arch, mode):
744744
if arch == 'none':
745-
name = 'out/Debug/node' if mode == 'debug' else 'out/Release/node'
745+
name = 'out/Debug/iojs' if mode == 'debug' else 'out/Release/iojs'
746746
else:
747-
name = 'out/%s.%s/node' % (arch, mode)
747+
name = 'out/%s.%s/iojs' % (arch, mode)
748748

749749
# Currently GYP does not support output_dir for MSVS.
750750
# http://code.google.com/p/gyp/issues/detail?id=40
751-
# It will put the builds into Release/node.exe or Debug/node.exe
751+
# It will put the builds into Release/iojs.exe or Debug/iojs.exe
752752
if utils.IsWindows():
753753
out_dir = os.path.join(dirname(__file__), "..", "out")
754754
if not exists(out_dir):
755755
if mode == 'debug':
756-
name = os.path.abspath('Debug/node.exe')
756+
name = os.path.abspath('Debug/iojs.exe')
757757
else:
758-
name = os.path.abspath('Release/node.exe')
758+
name = os.path.abspath('Release/iojs.exe')
759759
else:
760760
name = os.path.abspath(name + '.exe')
761761

0 commit comments

Comments
 (0)