Skip to content

Commit e72b5ec

Browse files
committed
doc: improve the workflow to test release binaries
1 parent 37e5152 commit e72b5ec

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

doc/contributing/releases.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -603,12 +603,18 @@ the build before moving forward. Use the following list as a baseline:
603603
must be in the expected updated version)
604604
* npm version (check it matches what we expect)
605605
* Run the test suite against the built binaries (optional)
606+
* Remember to use the proposal branch
607+
* Run `make build-addons` before running the tests
608+
* Remove `config.gypi` file
606609

607610
```console
608611
./tools/test.py --shell ~/Downloads/node-v18.5.0-linux-x64/bin/node
609612
```
610613

611-
<sup>There may be test issues if the branch used to test does not match the Node.js binary.</sup>
614+
<sup>There may be test issues if the binary used to test does not match to
615+
the expected variables.
616+
This usually happens on `test-child-process-stdio-overlapped.js` and
617+
`test-process-config` tests</sup>
612618

613619
### 11. Tag and sign the release commit
614620

0 commit comments

Comments
 (0)