File tree Expand file tree Collapse file tree 1 file changed +7
-1
lines changed Expand file tree Collapse file tree 1 file changed +7
-1
lines changed Original file line number Diff line number Diff line change @@ -603,12 +603,18 @@ the build before moving forward. Use the following list as a baseline:
603
603
must be in the expected updated version)
604
604
* npm version (check it matches what we expect)
605
605
* Run the test suite against the built binaries (optional)
606
+ * Remember to use the proposal branch
607
+ * Run ` make build-addons ` before running the tests
608
+ * Remove ` config.gypi ` file
606
609
607
610
``` console
608
611
./tools/test.py --shell ~/Downloads/node-v18.5.0-linux-x64/bin/node
609
612
```
610
613
611
- <sup >There may be test issues if the branch used to test does not match the Node.js binary.</sup >
614
+ <sup >There may be test issues if the binary used to test does not match to
615
+ the expected variables.
616
+ This usually happens on ` test-child-process-stdio-overlapped.js ` and
617
+ ` test-process-config ` tests</sup >
612
618
613
619
### 11. Tag and sign the release commit
614
620
You can’t perform that action at this time.
0 commit comments