Skip to content

Commit d0b8959

Browse files
thunder-codingaduh95
authored andcommitted
deps: use proper C standard when building libuv
Upstream libuv commits: libuv/libuv@bb706f5 libuv/libuv@018363a libuv was updated to 1.51.0 in 0315283. v1.51.0 was the release updating from c90 to c11. The standard was back then also updated from c89 to c90. and C89 was never an official standard to begin with. So, I wonder how this managed to stay without breaking anyone's builds for this long. This atleast breaks the builds for Android using NDK r28b and r28a, as LLONG_MAX is not defined by the Clang compiler for older C standards. Fixes: ../../deps/uv/src/unix/linux.c:2331:36: error: use of undeclared identifier 'LLONG_MAX' 2331 | constraint->quota_per_period = LLONG_MAX; | ^ 1 error generated. PR-URL: #58587 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
1 parent fcef56c commit d0b8959

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

deps/uv/uv.gyp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@
190190
'-Wno-unused-parameter',
191191
'-Wstrict-prototypes',
192192
],
193-
'OTHER_CFLAGS': [ '-g', '--std=gnu89' ],
193+
'OTHER_CFLAGS': [ '-g', '--std=gnu11' ],
194194
},
195195
'conditions': [
196196
[ 'OS=="win"', {
@@ -262,7 +262,7 @@
262262
'cflags': [
263263
'-fvisibility=hidden',
264264
'-g',
265-
'--std=gnu89',
265+
'--std=gnu11',
266266
'-Wall',
267267
'-Wextra',
268268
'-Wno-unused-parameter',

0 commit comments

Comments
 (0)