Skip to content

Commit cb448d5

Browse files
committed
tools: don't gitignore base64 config.h
The file is checked into git. Ignoring it causes a very non-obvious way of breaking tarball builds: 1. Download and unpack tarball 2. Check the sources into git with `git init; git add .; git commit -a` 3. Clean the source tree with `git clean -dfx` 4. Run `./configure && make` 5. Observe build failure because config.h is missing Fixes: #47638
1 parent 5275843 commit cb448d5

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

tools/dep_updaters/update-base64.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,11 @@ mv "$WORKSPACE/base64" "$DEPS_DIR/base64/"
4949

5050
# Build configuration is handled by `deps/base64/base64.gyp`, but since `config.h` has to be present for the build
5151
# to work, we create it and leave it empty.
52-
echo "// Intentionally empty" >> "$DEPS_DIR/base64/base64/lib/config.h"
52+
echo "// Intentionally empty" > "$DEPS_DIR/base64/base64/lib/config.h"
53+
54+
# Clear out .gitignore, otherwise config.h is ignored. That's dangerous when
55+
# people check in our tarballs into source control and run `git clean`.
56+
echo "# Intentionally empty" > "$DEPS_DIR/base64/base64/.gitignore"
5357

5458
echo "All done!"
5559
echo ""

0 commit comments

Comments
 (0)