Skip to content

Commit c6b9343

Browse files
targosRafaelGSS
authored andcommitted
src: enable Float16Array on global object
This feature is enabled in stable Chrome 136 but not in V8 by default. PR-URL: #58154 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
1 parent 69efb81 commit c6b9343

File tree

3 files changed

+2
-6
lines changed

3 files changed

+2
-6
lines changed

src/node.cc

+1
Original file line numberDiff line numberDiff line change
@@ -848,6 +848,7 @@ static ExitCode InitializeNodeWithArgsInternal(
848848
// These features are completed and enabled by default in Chrome, but not
849849
// in V8.
850850
V8::SetFlagsFromString("--js-explicit-resource-management");
851+
V8::SetFlagsFromString("--js-float16array");
851852

852853
#if defined(NODE_V8_OPTIONS)
853854
// Should come before the call to V8::SetFlagsFromCommandLine()

test/common/globals.js

+1
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const intrinsics = new Set([
3333
'Int8Array',
3434
'Uint16Array',
3535
'Int16Array',
36+
'Float16Array',
3637
'Uint32Array',
3738
'Int32Array',
3839
'Float32Array',

test/wpt/status/encoding.json

-6
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,6 @@
7070
"requires": ["full-icu"]
7171
},
7272
"encodeInto.any.js": {
73-
"fail": {
74-
"expected": [
75-
"Invalid encodeInto() destination: Float16Array, backed by: ArrayBuffer",
76-
"Invalid encodeInto() destination: Float16Array, backed by: SharedArrayBuffer"
77-
]
78-
},
7973
"requires": ["small-icu"]
8074
},
8175
"textdecoder-copy.any.js": {

0 commit comments

Comments
 (0)