Skip to content

Commit c5763e8

Browse files
addaleaxBethGriggs
authored andcommitted
test: wait for message from parent in embedding cctest
I’ve seen this fail a few times in CI, presumably because the inspector commmand did not reach the child thread in time. Explicitly waiting seems to solve that. Refs: #30467 PR-URL: #32563 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent f693dbd commit c5763e8

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

test/cctest/test_environment.cc

+1
Original file line numberDiff line numberDiff line change
@@ -406,6 +406,7 @@ TEST_F(EnvironmentTest, InspectorMultipleEmbeddedEnvironments) {
406406

407407
v8::Local<v8::Value> extracted_value = LoadEnvironment(
408408
environment,
409+
"while (!global.variableFromParent) {}\n"
409410
"return global.variableFromParent;",
410411
std::move(data->inspector_parent_handle)).ToLocalChecked();
411412

0 commit comments

Comments
 (0)