Skip to content

Commit 9da76fd

Browse files
treysisnodejs-github-bot
authored andcommitted
dns: fix test suite, part 1
PR-URL: #39987 Fixes: #31566 Refs: #6307 Refs: #20710 Refs: #38099 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent 1e2a649 commit 9da76fd

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

test/common/inspector-helper.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ class NodeInstance extends EventEmitter {
392392
console.log('[test]', `Testing ${path}`);
393393
const headers = hostHeaderValue ? { 'Host': hostHeaderValue } : null;
394394
return this.portPromise.then((port) => new Promise((resolve, reject) => {
395-
const req = http.get({ host, port, path, headers }, (res) => {
395+
const req = http.get({ host, port, family: 4, path, headers }, (res) => {
396396
let response = '';
397397
res.setEncoding('utf8');
398398
res
@@ -418,6 +418,7 @@ class NodeInstance extends EventEmitter {
418418
const port = await this.portPromise;
419419
return http.get({
420420
port,
421+
family: 4,
421422
path: parseURL(devtoolsUrl).path,
422423
headers: {
423424
'Connection': 'Upgrade',

test/parallel/test-cluster-message.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ if (cluster.isWorker) {
6060
maybeReply();
6161
});
6262

63-
server.listen(0, '127.0.0.1');
63+
server.listen(0);
6464
} else if (cluster.isPrimary) {
6565

6666
const checks = {

test/sequential/test-https-connect-localport.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const assert = require('assert');
2323
host: 'localhost',
2424
pathname: '/',
2525
port,
26-
family: 4,
26+
//family: 4,
2727
localPort: common.PORT,
2828
rejectUnauthorized: false,
2929
}, common.mustCall(() => {

test/sequential/test-net-connect-local-error.js

+2
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,14 @@ const expectedErrorCodes = ['ECONNREFUSED', 'EADDRINUSE'];
99

1010
const optionsIPv4 = {
1111
port: common.PORT,
12+
family: 4,
1213
localPort: common.PORT + 1,
1314
localAddress: common.localhostIPv4
1415
};
1516

1617
const optionsIPv6 = {
1718
host: '::1',
19+
family: 6,
1820
port: common.PORT + 2,
1921
localPort: common.PORT + 3,
2022
localAddress: '::1',

0 commit comments

Comments
 (0)