Skip to content

Commit 8bf16cd

Browse files
deps: patch V8 to 12.8.374.16
Refs: v8/v8@12.8.374.13...12.8.374.16
1 parent 9e83853 commit 8bf16cd

File tree

6 files changed

+30
-10
lines changed

6 files changed

+30
-10
lines changed

deps/v8/include/v8-version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 12
1212
#define V8_MINOR_VERSION 8
1313
#define V8_BUILD_NUMBER 374
14-
#define V8_PATCH_LEVEL 13
14+
#define V8_PATCH_LEVEL 16
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

deps/v8/src/objects/js-date-time-format.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1845,7 +1845,7 @@ std::unique_ptr<icu::SimpleDateFormat> CreateICUDateFormat(
18451845
// has to be discussed. Revisit once the spec is clarified/revised.
18461846
icu::UnicodeString pattern;
18471847
UErrorCode status = U_ZERO_ERROR;
1848-
pattern = generator->getBestPattern(skeleton, UDATPG_MATCH_ALL_FIELDS_LENGTH,
1848+
pattern = generator->getBestPattern(skeleton, UDATPG_MATCH_HOUR_FIELD_LENGTH,
18491849
status);
18501850
pattern = ReplaceHourCycleInPattern(pattern, hc);
18511851
DCHECK(U_SUCCESS(status));

deps/v8/src/objects/shared-function-info-inl.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -615,6 +615,7 @@ bool SharedFunctionInfo::HasOuterScopeInfo() const {
615615
Tagged<ScopeInfo> outer_info;
616616
Tagged<ScopeInfo> info = scope_info(kAcquireLoad);
617617
if (info->IsEmpty()) {
618+
if (is_compiled()) return false;
618619
if (!IsScopeInfo(outer_scope_info())) return false;
619620
outer_info = Cast<ScopeInfo>(outer_scope_info());
620621
} else {

deps/v8/src/wasm/wasm-js.cc

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2453,9 +2453,13 @@ void WebAssemblyPromising(const v8::FunctionCallbackInfo<v8::Value>& info) {
24532453
i::DirectHandle<i::WasmExportedFunctionData> data(
24542454
wasm_exported_function->shared()->wasm_exported_function_data(),
24552455
i_isolate);
2456+
if (data->instance_data()->module_object()->is_asm_js()) {
2457+
thrower.TypeError("Argument 0 must be a WebAssembly exported function");
2458+
return;
2459+
}
24562460
bool with_suspender_param = false;
2457-
i::Handle<i::JSFunction> result = NewPromisingWasmExportedFunction(
2458-
i_isolate, data, thrower, with_suspender_param);
2461+
i::Handle<i::JSFunction> result =
2462+
NewPromisingWasmExportedFunction(i_isolate, data, thrower, with_suspender_param);
24592463
info.GetReturnValue().Set(Utils::ToLocal(i::Cast<i::JSObject>(result)));
24602464
return;
24612465
}

deps/v8/test/intl/regress-40855035.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

deps/v8/test/mjsunit/wasm/stack-switching.js

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,27 @@ d8.file.execute("test/mjsunit/wasm/wasm-module-builder.js");
9999
let wrapper = ToPromising(instance.exports.test);
100100
})();
101101

102+
(function TestInvalidWrappers() {
103+
print(arguments.callee.name);
104+
assertThrows(() => WebAssembly.promising({}), TypeError,
105+
/Argument 0 must be a function/);
106+
assertThrows(() => WebAssembly.promising(() => {}), TypeError,
107+
/Argument 0 must be a WebAssembly exported function/);
108+
assertThrows(() => WebAssembly.Suspending(() => {}), TypeError,
109+
/WebAssembly.Suspending must be invoked with 'new'/);
110+
assertThrows(() => new WebAssembly.Suspending({}), TypeError,
111+
/Argument 0 must be a function/);
112+
function asmModule() {
113+
"use asm";
114+
function x(v) {
115+
v = v | 0;
116+
}
117+
return x;
118+
}
119+
assertThrows(() => WebAssembly.promising(asmModule()), TypeError,
120+
/Argument 0 must be a WebAssembly exported function/);
121+
})();
122+
102123
(function TestStackSwitchNoSuspend() {
103124
print(arguments.callee.name);
104125
let builder = new WasmModuleBuilder();

0 commit comments

Comments
 (0)