Skip to content

Commit 8a8416f

Browse files
committed
lib: use full URL to GitHub issues in comments
Don't assume the reader of the code will know where to find the issue tracker. Provide the full URL. This is especially important if the issue tracker should move again. PR-URL: #34686 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ricky Zhou <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Mary Marchini <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent bcfb176 commit 8a8416f

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

lib/internal/event_target.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,8 @@ function initEventTarget(self) {
201201

202202
class EventTarget {
203203
// Used in checking whether an object is an EventTarget. This is a well-known
204-
// symbol as EventTarget may be used cross-realm. See discussion in #33661.
204+
// symbol as EventTarget may be used cross-realm.
205+
// Ref: https://github.com/nodejs/node/pull/33661
205206
static [kIsEventTarget] = true;
206207

207208
constructor() {
@@ -520,8 +521,8 @@ function validateEventListenerOptions(options) {
520521
// Test whether the argument is an event object. This is far from a fool-proof
521522
// test, for example this input will result in a false positive:
522523
// > isEventTarget({ constructor: EventTarget })
523-
// It stands in its current implementation as a compromise. For the relevant
524-
// discussion, see #33661.
524+
// It stands in its current implementation as a compromise.
525+
// Ref: https://github.com/nodejs/node/pull/33661
525526
function isEventTarget(obj) {
526527
return obj && obj.constructor && obj.constructor[kIsEventTarget];
527528
}

lib/internal/stream_base_commons.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,8 @@ function onStreamRead(arrayBuffer) {
208208
}
209209

210210
if (nread !== UV_EOF) {
211-
// #34375 CallJSOnreadMethod expects the return value to be a buffer.
211+
// CallJSOnreadMethod expects the return value to be a buffer.
212+
// Ref: https://github.com/nodejs/node/pull/34375
212213
stream.destroy(errnoException(nread, 'read'));
213214
return;
214215
}
@@ -228,7 +229,8 @@ function onStreamRead(arrayBuffer) {
228229
if (handle.readStop) {
229230
const err = handle.readStop();
230231
if (err) {
231-
// #34375 CallJSOnreadMethod expects the return value to be a buffer.
232+
// CallJSOnreadMethod expects the return value to be a buffer.
233+
// Ref: https://github.com/nodejs/node/pull/34375
232234
stream.destroy(errnoException(err, 'read'));
233235
return;
234236
}

0 commit comments

Comments
 (0)