Skip to content

Commit 788d736

Browse files
addaleaxMylesBorins
authored andcommitted
doc: typographical fixes in COLLABORATOR_GUIDE.md
Fix a typo and add a missing line break. PR-URL: #11163 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Nikolai Vavilov <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
1 parent 533d2bf commit 788d736

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

COLLABORATOR_GUIDE.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ followed to determine which aspects of the Node.js API are considered
119119

120120
Exception to each of these points can be made if use or behavior of a given
121121
internal API can be demonstrated to be sufficiently relied upon by the Node.js
122-
ecosystem such that any changes would cause too much breakage. The threshhold
122+
ecosystem such that any changes would cause too much breakage. The threshold
123123
for what qualifies as "too much breakage" is to be decided on a case-by-case
124124
basis by the CTC.
125125

@@ -158,7 +158,8 @@ sufficient review by collaborators and approval of at least two CTC members.
158158

159159
Examples of breaking changes include, but are not necessarily limited to,
160160
removal or redefinition of existing API arguments, changing return values
161-
(except when return values do not currently exist), removing or modifying existing properties on an options argument, adding or removing errors,
161+
(except when return values do not currently exist), removing or modifying
162+
existing properties on an options argument, adding or removing errors,
162163
changing error messages in any way, altering expected timing of an event (e.g.
163164
moving from sync to async responses or vice versa), and changing the
164165
non-internal side effects of using a particular API.

0 commit comments

Comments
 (0)