Skip to content

Commit 75e3283

Browse files
mmarchiniMylesBorins
authored andcommitted
build: set --v8-enable-object-print by default
The flag improves the experience of debugging V8 with native debuggers. It doens't incur performance penality, the only downside is an increase in binary size by approximately 248 Kb. Ref: #32834 PR-URL: #34705 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: David Carlier <[email protected]>
1 parent ef356f6 commit 75e3283

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

common.gypi

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,9 @@
5454
# Enable disassembler for `--print-code` v8 options
5555
'v8_enable_disassembler': 1,
5656

57+
# Sets -dOBJECT_PRINT.
58+
'v8_enable_object_print%': 1,
59+
5760
# https://github.com/nodejs/node/pull/22920/files#r222779926
5861
'v8_enable_handle_zapping': 0,
5962

configure.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -662,7 +662,7 @@
662662
parser.add_option('--v8-enable-object-print',
663663
action='store_true',
664664
dest='v8_enable_object_print',
665-
default=False,
665+
default=True,
666666
help='compile V8 with auxiliar functions for native debuggers')
667667

668668
parser.add_option('--node-builtin-modules-path',

0 commit comments

Comments
 (0)