Skip to content

Commit 6bddf58

Browse files
Ethan-Arrowoodtargos
authored andcommitted
dns: fix dns query cache implementation
PR-URL: #58404 Refs: #57640 Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Tim Perry <[email protected]>
1 parent b8c3319 commit 6bddf58

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/cares_wrap.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -879,9 +879,9 @@ void ChannelWrap::Setup() {
879879
}
880880

881881
/* We do the call to ares_init_option for caller. */
882-
const int optmask =
883-
ARES_OPT_FLAGS | ARES_OPT_TIMEOUTMS |
884-
ARES_OPT_SOCK_STATE_CB | ARES_OPT_TRIES;
882+
const int optmask = ARES_OPT_FLAGS | ARES_OPT_TIMEOUTMS |
883+
ARES_OPT_SOCK_STATE_CB | ARES_OPT_TRIES |
884+
ARES_OPT_QUERY_CACHE;
885885
r = ares_init_options(&channel_, &options, optmask);
886886

887887
if (r != ARES_SUCCESS) {

test/parallel/test-dns.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ assert.throws(() => {
415415
(answer) => Object.assign({ domain }, answer)
416416
),
417417
}), port, address);
418-
}, cases.length * 2 - 1));
418+
}, cases.length * 2));
419419

420420
server.bind(0, common.mustCall(() => {
421421
const address = server.address();

0 commit comments

Comments
 (0)