Skip to content

Commit 6b6c628

Browse files
mhdawsonMylesBorins
authored andcommitted
test: improve code coverage for i18n
Coverage report for src/node_i18n.cc shows that the Has() method is not covered. This test adds coverage for that method. PR-URL: #25428 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent d5316e0 commit 6b6c628

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

test/parallel/test-icu-punycode.js

+6
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,12 @@ if (!common.hasIntl)
77
const icu = process.binding('icu');
88
const assert = require('assert');
99

10+
// test hasConverter method
11+
assert(icu.hasConverter('utf-8'),
12+
'hasConverter should report coverter exists for utf-8');
13+
assert(!icu.hasConverter('x'),
14+
'hasConverter should report coverter does not exist for x');
15+
1016
const tests = require('../fixtures/url-idna.js');
1117
const wptToASCIITests = require('../fixtures/url-toascii.js');
1218

0 commit comments

Comments
 (0)