Skip to content

Commit 6a45ac0

Browse files
mscdexMylesBorins
authored andcommitted
build: fix newlines in addon build output
Interpretation of escape sequences with echo is not as consistent across platforms as printf, so use the latter instead. PR-URL: #11466 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent da2adb7 commit 6a45ac0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ test/addons/.buildstamp: config.gypi \
156156
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
157157
# embedded addons have been generated from the documentation.
158158
@for dirname in test/addons/*/; do \
159-
echo "\nBuilding addon $$PWD/$$dirname" ; \
159+
printf "\nBuilding addon $$PWD/$$dirname\n" ; \
160160
env MAKEFLAGS="-j1" $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp \
161161
--loglevel=$(LOGLEVEL) rebuild \
162162
--python="$(PYTHON)" \

0 commit comments

Comments
 (0)