Skip to content

Commit 63f5d69

Browse files
sygtargos
authored andcommitted
deps: V8: cherry-pick 4f38995c8295
Original commit message: [explicit-resource-management] Turn flag on by default This feature has shipped since M134 on the blink side, and is highly unlikely to be unshipped now, so flip the flag on. Bug: 42203506 Change-Id: I9554cea721983464b150c0de70b58a4b50fd477b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6513391 Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]> Commit-Queue: Shu-yu Guo <[email protected]> Cr-Commit-Position: refs/heads/main@{#100069} Refs: v8/v8@4f38995 PR-URL: #58230 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>
1 parent 5a5f6bb commit 63f5d69

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.14',
41+
'v8_embedder_string': '-node.15',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/src/flags/flag-definitions.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,6 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features")
295295
// Features that are complete (but still behind the --harmony flag).
296296
#define HARMONY_STAGED_BASE(V)
297297
#define JAVASCRIPT_STAGED_FEATURES_BASE(V) \
298-
V(js_explicit_resource_management, "explicit resource management") \
299298
V(js_float16array, \
300299
"Float16Array, Math.f16round, DataView.getFloat16, DataView.setFloat16")
301300

@@ -311,7 +310,7 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features")
311310
#endif
312311

313312
// Features that are shipping (turned on by default, but internal flag remains).
314-
#define HARMONY_SHIPPING_BASE(V) \
313+
#define HARMONY_SHIPPING_BASE(V) \
315314
V(harmony_import_attributes, "harmony import attributes")
316315

317316
#define JAVASCRIPT_SHIPPING_FEATURES_BASE(V) \
@@ -320,7 +319,8 @@ DEFINE_BOOL(js_shipping, true, "enable all shipped JavaScript features")
320319
V(js_promise_try, "Promise.try") \
321320
V(js_atomics_pause, "Atomics.pause") \
322321
V(js_error_iserror, "Error.isError") \
323-
V(js_regexp_escape, "RegExp.escape")
322+
V(js_regexp_escape, "RegExp.escape") \
323+
V(js_explicit_resource_management, "explicit resource management")
324324

325325
#ifdef V8_INTL_SUPPORT
326326
#define HARMONY_SHIPPING(V) HARMONY_SHIPPING_BASE(V)

deps/v8/test/mjsunit/es6/iterator-prototype.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ var iteratorPrototype = arrayIteratorPrototype.__proto__;
99
assertSame(Object.prototype, Object.getPrototypeOf(iteratorPrototype));
1010
assertTrue(Object.isExtensible(iteratorPrototype));
1111
assertSame(12, Object.getOwnPropertyNames(iteratorPrototype).length);
12-
assertSame(2, Object.getOwnPropertySymbols(iteratorPrototype).length);
12+
assertSame(3, Object.getOwnPropertySymbols(iteratorPrototype).length);
1313
assertSame(Symbol.iterator,
1414
Object.getOwnPropertySymbols(iteratorPrototype)[0]);
1515

0 commit comments

Comments
 (0)