Skip to content

Commit 3ba02da

Browse files
committed
test: add tests for maxHeaderSize setting in http2
Refs: #33636
1 parent 984132d commit 3ba02da

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

test/parallel/test-http2-getpackedsettings.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ assert.deepStrictEqual(val, check);
2626
['maxConcurrentStreams', 0],
2727
['maxConcurrentStreams', 2 ** 31 - 1],
2828
['maxHeaderListSize', 0],
29-
['maxHeaderListSize', 2 ** 32 - 1]
29+
['maxHeaderListSize', 2 ** 32 - 1],
30+
['maxHeaderSize', 0],
31+
['maxHeaderSize', 2 ** 32 - 1]
3032
].forEach((i) => {
3133
// Valid options should not throw.
3234
http2.getPackedSettings({ [i[0]]: i[1] });
@@ -45,7 +47,9 @@ http2.getPackedSettings({ enablePush: false });
4547
['maxConcurrentStreams', -1],
4648
['maxConcurrentStreams', 2 ** 32],
4749
['maxHeaderListSize', -1],
48-
['maxHeaderListSize', 2 ** 32]
50+
['maxHeaderListSize', 2 ** 32],
51+
['maxHeaderSize', -1],
52+
['maxHeaderSize', 2 ** 32]
4953
].forEach((i) => {
5054
assert.throws(() => {
5155
http2.getPackedSettings({ [i[0]]: i[1] });
@@ -97,6 +101,7 @@ http2.getPackedSettings({ enablePush: false });
97101
maxFrameSize: 20000,
98102
maxConcurrentStreams: 200,
99103
maxHeaderListSize: 100,
104+
maxHeaderSize: 100,
100105
enablePush: true,
101106
enableConnectProtocol: false,
102107
foo: 'ignored'
@@ -149,6 +154,7 @@ http2.getPackedSettings({ enablePush: false });
149154
assert.strictEqual(settings.maxFrameSize, 20000);
150155
assert.strictEqual(settings.maxConcurrentStreams, 200);
151156
assert.strictEqual(settings.maxHeaderListSize, 100);
157+
assert.strictEqual(settings.maxHeaderSize, 100);
152158
assert.strictEqual(settings.enablePush, true);
153159
assert.strictEqual(settings.enableConnectProtocol, false);
154160
}

0 commit comments

Comments
 (0)