Skip to content

Commit 2c6cf90

Browse files
targosMylesBorins
authored andcommitted
deps: V8: cherry-pick 50031fae736f
Original commit message: [compiler] Explicitly initialize const members This fixes a compilation error in Node.js with Xcode: initialize the const member 'blueprint_'. error: constructor for 'v8::internal::compiler::Callee' must explicitly Change-Id: Ia55398428d0de35a9ad5132eabd22d0adb694514 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1895561 Commit-Queue: Jakob Gruber <[email protected]> Reviewed-by: Jakob Gruber <[email protected]> Cr-Commit-Position: refs/heads/master@{#64719} Refs: v8/v8@50031fa Backport-PR-URL: #30513 PR-URL: #30020 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
1 parent 1e5e8c3 commit 2c6cf90

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939

4040
# Reset this number to 0 on major V8 upgrades.
4141
# Increment by one for each non-official patch applied to deps/v8.
42-
'v8_embedder_string': '-node.18',
42+
'v8_embedder_string': '-node.19',
4343

4444
##### V8 defaults for Node.js #####
4545

deps/v8/src/compiler/serializer-for-background-compilation.cc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -387,8 +387,10 @@ class CompilationSubject {
387387
// always has a FunctionBlueprint.
388388
class Callee {
389389
public:
390-
explicit Callee(Handle<JSFunction> jsfunction) : jsfunction_(jsfunction) {}
391-
explicit Callee(FunctionBlueprint const& blueprint) : blueprint_(blueprint) {}
390+
explicit Callee(Handle<JSFunction> jsfunction)
391+
: jsfunction_(jsfunction), blueprint_() {}
392+
explicit Callee(FunctionBlueprint const& blueprint)
393+
: jsfunction_(), blueprint_(blueprint) {}
392394

393395
Handle<SharedFunctionInfo> shared(Isolate* isolate) const {
394396
return blueprint_.has_value()

0 commit comments

Comments
 (0)