Skip to content

Commit 101bca9

Browse files
ferosssilverwind
authored andcommitted
buffer: remove deprecated buffer.get/.set methods
These have been deprecated since Apr 27, 2013, and the plan was to remove them in "node v0.13". buffer.get(index) is superseded by buffer[index]. buffer.set(index, value) is superseded by buffer[index] = value. These have never been documented at any point in node's history. PR-URL: #4594 Fixes: #4587 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Roman Reiss <[email protected]>
1 parent b40aca1 commit 101bca9

File tree

1 file changed

+0
-18
lines changed

1 file changed

+0
-18
lines changed

lib/buffer.js

-18
Original file line numberDiff line numberDiff line change
@@ -523,24 +523,6 @@ Buffer.prototype.fill = function fill(val, start, end) {
523523
};
524524

525525

526-
// XXX remove in v0.13
527-
Buffer.prototype.get = internalUtil.deprecate(function get(offset) {
528-
offset = ~~offset;
529-
if (offset < 0 || offset >= this.length)
530-
throw new RangeError('Index out of range');
531-
return this[offset];
532-
}, 'Buffer.get is deprecated. Use array indexes instead.');
533-
534-
535-
// XXX remove in v0.13
536-
Buffer.prototype.set = internalUtil.deprecate(function set(offset, v) {
537-
offset = ~~offset;
538-
if (offset < 0 || offset >= this.length)
539-
throw new RangeError('Index out of range');
540-
return this[offset] = v;
541-
}, 'Buffer.set is deprecated. Use array indexes instead.');
542-
543-
544526
// TODO(trevnorris): fix these checks to follow new standard
545527
// write(string, offset = 0, length = buffer.length, encoding = 'utf8')
546528
var writeWarned = false;

0 commit comments

Comments
 (0)