fixup! src: fix external module env and kDisableNodeOptionsEnv

RafaelGSS · RafaelGSS · commit 0b16434b124d · 2024-05-17T11:21:10.000-03:00
diff --git a/src/node.cc b/src/node.cc
@@ -879,7 +879,7 @@ static ExitCode InitializeNodeWithArgsInternal(
         !node_repl_external_env.empty()) {
       errors->emplace_back("NODE_REPL_EXTERNAL_MODULE can't be used with "
                            "kDisableNodeOptionsEnv");
-      return ExitCode::kBootstrapFailure;
+      return ExitCode::kInvalidCommandLineArgument;
     }
   }
 #endif
diff --git a/test/embedding/test-embedding.js b/test/embedding/test-embedding.js
@@ -163,7 +163,7 @@ for (const extraSnapshotArgs of [
       },
     },
     {
-      status: 10,
+      status: 9,
       signal: null,
       stderr: `${binary}: NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv\n`,
     });

Original file line number	Diff line number	Diff line change
`@@ -879,7 +879,7 @@ static ExitCode InitializeNodeWithArgsInternal(`
`879`	`879`	`!node_repl_external_env.empty()) {`
`880`	`880`	`errors->emplace_back("NODE_REPL_EXTERNAL_MODULE can't be used with "`
`881`	`881`	`"kDisableNodeOptionsEnv");`
`882`		`- return ExitCode::kBootstrapFailure;`
	`882`	`+ return ExitCode::kInvalidCommandLineArgument;`
`883`	`883`	`}`
`884`	`884`	`}`
`885`	`885`	`#endif`
Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ for (const extraSnapshotArgs of [`
`163`	`163`	`},`
`164`	`164`	`},`
`165`	`165`	`{`
`166`		`- status: 10,`
	`166`	`+ status: 9,`
`167`	`167`	`signal: null,`
`168`	`168`	stderr: `${binary}: NODE_REPL_EXTERNAL_MODULE can't be used with kDisableNodeOptionsEnv\n`,
`169`	`169`	`});`