Skip to content

Commit 04d78dd

Browse files
targosmarco-ippolito
authored andcommitted
tools: remove no-goma arg from make-v8 script
V8 recently removed its support and passing it makes canary builds fail. It should be safe to remove it now as the default behavior is to look for goma in the PATH, and CI hosts shouldn't have goma installed. Refs: v8/v8@6c5a6c0 PR-URL: #53336 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 76f3bb3 commit 04d78dd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/make-v8.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,6 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then
5555
else
5656
DEPOT_TOOLS_DIR="$(cd _depot_tools && pwd)"
5757
# shellcheck disable=SC2086
58-
PATH="$DEPOT_TOOLS_DIR":$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" --no-goma $V8_BUILD_OPTIONS
58+
PATH="$DEPOT_TOOLS_DIR":$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" $V8_BUILD_OPTIONS
5959
PATH="$DEPOT_TOOLS_DIR":$PATH ninja -C "out.gn/$BUILD_ARCH_TYPE/" "${JOBS_ARG}" d8 cctest inspector-test
6060
fi

0 commit comments

Comments
 (0)