build: i18n: windows work, refactor

* start to refactor download module
* work on the windows files

Author: srl295

configure

@@ -15,6 +15,10 @@ root_dir = os.path.dirname(__file__)
 sys.path.insert(0, os.path.join(root_dir, 'tools', 'gyp', 'pylib'))
 from gyp.common import GetFlavor
 
+# imports in tools/configure.d
+sys.path.insert(0, os.path.join(root_dir, 'tools', 'configure.d'))
+import nodedownload
+
 # parse our options
 parser = optparse.OptionParser()
 
@@ -722,12 +726,11 @@ def icu_download(path):
       'md5': '6b89d60e2f0e140898ae4d7f72323bca',  
     },
   ]
-  def fmtMb(amt):
-    return "{:.1f}".format(amt / 1024000.)
-  spin = "\\|/-"
   def reporthook(count, size, total):
     sys.stdout.write('%c %sMB total, %sMB downloaded   \r' %
-                     (spin[count%4], fmtMb(total), fmtMb(count*size)))
+                     (nodedownload.spin(count),
+                      nodedownload.formatSize(total),
+                      nodedownload.formatSize(count*size)))
   for icu in icus:
     url = icu['url']
     md5 = icu['md5']

tools/configure.d/nodedownload.py

@@ -0,0 +1,10 @@
+# Moved some utilities here from ../../configure
+
+def formatSize(amt):
+    """Format a size as a string"""
+    return "{:.1f}".format(amt / 1024000.)
+
+def spin(c):
+    """print out a spinner based on 'c'"""
+    spin = "\\|/-"
+    return (spin[c % len(spin)])

vcbuild.bat

@@ -35,7 +35,7 @@ set noetw_msi_arg=
 set noperfctr=
 set noperfctr_arg=
 set noperfctr_msi_arg=
-set i18n_arg=
+set i18n_arg=small-icu
 
 :next-arg
 if "%1"=="" goto args-done
@@ -65,6 +65,7 @@ if /i "%1"=="upload"        set upload=1&goto arg-ok
 if /i "%1"=="jslint"        set jslint=1&goto arg-ok
 if /i "%1"=="small-icu"     set i18n_arg=%1&goto arg-ok
 if /i "%1"=="full-icu"      set i18n_arg=%1&goto arg-ok
+if /i "%1"=="intl-none"     set i18n_arg=%1&goto arg-ok
 
 echo Warning: ignoring invalid command line option `%1`.
 
@@ -85,6 +86,7 @@ if defined noperfctr set noperfctr_arg=--without-perfctr& set noperfctr_msi_arg=
 
 if "%i18n_arg%"=="full-icu" set i18n_arg=--with-intl=full-icu
 if "%i18n_arg%"=="small-icu" set i18n_arg=--with-intl=small-icu
+if "%i18n_arg%"=="intl-none" set i18n_arg=--with-intl=none
 
 :project-gen
 @rem Skip project generation if requested.
@@ -232,7 +234,7 @@ python tools/closure_linter/closure_linter/gjslint.py --unix_mode --strict --noj
 goto exit
 
 :help
-echo vcbuild.bat [debug/release] [msi] [test-all/test-uv/test-internet/test-pummel/test-simple/test-message] [clean] [noprojgen] [nobuild] [nosign] [x86/x64]
+echo vcbuild.bat [debug/release] [msi] [test-all/test-uv/test-internet/test-pummel/test-simple/test-message] [clean] [noprojgen] [small-icu/full-icu/intl-none] [nobuild] [nosign] [x86/x64]
 echo Examples:
 echo   vcbuild.bat                : builds release build
 echo   vcbuild.bat debug          : builds debug build