Skip to content

Commit 7110d1c

Browse files
committed
deps: replace mkdirp with {recursive} mkdir
only supported on Node.js 10+ Closes: #2084
1 parent a6b76a8 commit 7110d1c

File tree

3 files changed

+2
-5
lines changed

3 files changed

+2
-5
lines changed

lib/configure.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ const fs = require('graceful-fs')
44
const path = require('path')
55
const log = require('npmlog')
66
const os = require('os')
7-
const mkdirp = require('mkdirp')
87
const processRelease = require('./process-release')
98
const win = process.platform === 'win32'
109
const findNodeDirectory = require('./find-node-directory')
@@ -73,7 +72,7 @@ function configure (gyp, argv, callback) {
7372

7473
function createBuildDir () {
7574
log.verbose('build dir', 'attempting to create "build" dir: %s', buildDir)
76-
mkdirp(buildDir, function (err, isNew) {
75+
fs.mkdir(buildDir, { recursive: true }, function (err, isNew) {
7776
if (err) {
7877
return callback(err)
7978
}

lib/install.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ const crypto = require('crypto')
88
const log = require('npmlog')
99
const semver = require('semver')
1010
const request = require('request')
11-
const mkdir = require('mkdirp')
1211
const processRelease = require('./process-release')
1312
const win = process.platform === 'win32'
1413
const getProxyFromURI = require('./proxy')
@@ -114,7 +113,7 @@ function install (fs, gyp, argv, callback) {
114113
log.verbose('ensuring nodedir is created', devDir)
115114

116115
// first create the dir for the node dev files
117-
mkdir(devDir, function (err, created) {
116+
fs.mkdir(devDir, { recursive: true }, function (err, created) {
118117
if (err) {
119118
if (err.code === 'EACCES') {
120119
eaccesFallback(err)

package.json

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
"env-paths": "^2.2.0",
2626
"glob": "^7.1.4",
2727
"graceful-fs": "^4.2.3",
28-
"mkdirp": "^0.5.1",
2928
"nopt": "^4.0.3",
3029
"npmlog": "^4.1.2",
3130
"request": "^2.88.2",

0 commit comments

Comments
 (0)