Skip to content

docker documentation for config files is no longer valid #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alastair opened this issue Jul 23, 2020 · 6 comments
Open

docker documentation for config files is no longer valid #1450

alastair opened this issue Jul 23, 2020 · 6 comments

Comments

@alastair
Copy link

alastair commented Jul 23, 2020

The docker installation instructions (https://github.com/solid/node-solid-server#use-docker) have a step:

docker cp solid:/usr/src/app/config.json .

However by default this file doesn't exist, I get an error:

Error: No such container:path: solid:/usr/src/app/config.json

I was able to successfully create a config file using solid init and then copy it

perhaps these instructions need to be updated to cover some recent changes to the docker setup?

@bourgeoa
Copy link
Member

Thanks for raising the issue. The problem comes from the introduction of a solid docker image, which uses a different home folder (opt/solid/) than the original dockerfile (usr/src/app/).

Something should be updated.
@angelo-v what do you think : change the documentation or align docker image and dockerfile ?

  • align docker image and dockerfile has a big draw back : both are used in production
  • then change the documentation, may be the only feasible solution.

@angelo-v
Copy link
Contributor

We should clarify in the documentation, that the docker image is configured via environment variables (as it is common with docker). The config.json should not be used at all

@alastair
Copy link
Author

Thanks for the comment. This helpfully answers my questions in #1453 too

@TallTed
Copy link
Member

TallTed commented Nov 9, 2020

@angelo-v wrote:

The config.json should not be used at all

That's in direct contradiction to the current docs! (scroll up one paragraph from the header to which this links)

Configuring Solid via the config file can be a concise and convenient method and is the generally recommended approach.

(Quite likely, this should be combined with #1453.)

@angelo-v
Copy link
Contributor

angelo-v commented Nov 9, 2020

You are referring to a paragraph that is not about docker usage. My statement that you quote is about docker usage only.

@TallTed
Copy link
Member

TallTed commented Nov 12, 2020

@angelo-v -- Ah, sorry, my mis-read. :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants