Merge pull request #70 from ma314smith/fix-attribute-ns

unqualified attributes should have an empty namespace

Author: bjrmatos

lib/exclusive-canonicalization.js

@@ -14,11 +14,11 @@ ExclusiveCanonicalization.prototype.attrCompare = function(a,b) {
 
   var left = a.namespaceURI + a.localName
   var right = b.namespaceURI + b.localName
-  
+
   if (left===right) return 0
   else if (left<right) return -1
   else return 1
-  
+
 };
 
 ExclusiveCanonicalization.prototype.nsCompare = function(a,b) {
@@ -40,7 +40,6 @@ ExclusiveCanonicalization.prototype.renderAttrs = function(node, defaultNS) {
       attr = node.attributes[i];
       //ignore namespace definition attributes
       if (attr.name.indexOf("xmlns") === 0) { continue; }
-      if (!attr.namespaceURI && defaultNS) { attr.namespaceURI = defaultNS; }
       attrListToRender.push(attr);
     }
   }
@@ -123,7 +122,7 @@ ExclusiveCanonicalization.prototype.renderNs = function(node, prefixesInScope, d
 };
 
 ExclusiveCanonicalization.prototype.processInner = function(node, prefixesInScope, defaultNs, inclusiveNamespacesPrefixList) {
-  
+
   if (node.nodeType === 8) { return this.renderComment(node); }
   if (node.data) { return utils.normalizeXmlIncludingCR(node.data); }
 

package.json

@@ -34,6 +34,6 @@
     }
   ],
   "scripts": {
-    "test": "nodeunit ./test/canonicalization-unit-tests.js ./test/c14nWithComments-unit-tests.js ./test/signature-unit-tests.js ./test/saml-response-test.js ./test/signature-integration-tests.js ./test/document-test.js"
+    "test": "nodeunit ./test/canonicalization-unit-tests.js ./test/c14nWithComments-unit-tests.js ./test/signature-unit-tests.js ./test/saml-response-test.js ./test/signature-integration-tests.js ./test/document-test.js ./test/wsfed-metadata-test.js"
   }
 }

test/static/wsfederation_metadata.pem

@@ -0,0 +1,18 @@
+-----BEGIN CERTIFICATE-----
+MIIC4jCCAcqgAwIBAgIQQNXrmzhLN4VGlUXDYCRT3zANBgkqhkiG9w0BAQsFADAt
+MSswKQYDVQQDEyJhY2NvdW50cy5hY2Nlc3Njb250cm9sLndpbmRvd3MubmV0MB4X
+DTE0MTAyODAwMDAwMFoXDTE2MTAyNzAwMDAwMFowLTErMCkGA1UEAxMiYWNjb3Vu
+dHMuYWNjZXNzY29udHJvbC53aW5kb3dzLm5ldDCCASIwDQYJKoZIhvcNAQEBBQAD
+ggEPADCCAQoCggEBALyKs/uPhEf7zVizjfcr/ISGFe9+yUOqwpel38zgutvLHmFD
+39E2hpPdQhcXn4c4dt1fU5KvkbcDdVbP8+e4TvNpJMy/nEB2V92zCQ/hhBjilwhF
+1ETe1TMmVjALs0KFvbxW9ZN3EdUVvxFvz/gvG29nQhl4QWKj3x8opr89lmq14Z7T
+0mzOV8kub+cgsOU/1bsKqrIqN1fMKKFhjKaetctdjYTfGzVQ0AJAzzbtg0/Q1wdY
+NAnhSDafygEv6kNiquk0r0RyasUUevEXs2LY3vSgKsKseI8ZZlQEMtE9/k/iAG7J
+NcEbVg53YTurNTrPnXJOU88mf3TToX14HpYsS1ECAwEAATANBgkqhkiG9w0BAQsF
+AAOCAQEAfolx45w0i8CdAUjjeAaYdhG9+NDHxop0UvNOqlGqYJexqPLuvX8iyUaY
+xNGzZxFgGI3GpKfmQP2JQWQ1E5JtY/n8iNLOKRMwqkuxSCKJxZJq4Sl/m/Yv7TS1
+P5LNgAj8QLCypxsWrTAmq2HSpkeSk4JBtsYxX6uhbGM/K1sEktKybVTHu22/7TmR
+qWTmOUy9wQvMjJb2IXdMGLG3hVntN/WWcs5w8vbt1i8Kk6o19W2MjZ95JaECKjBD
+YRlhG1KmSBtrsKsCBQoBzwH/rXfksTO9JoUYLXiW0IppB7DhNH4PJ5hZI91R8rR0
+H3/bKkLSuDaKLWSqMhozdhXsIIKvJQ==
+-----END CERTIFICATE-----