Skip to content

Support id attribute variations? #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lukehorvat opened this issue Jun 24, 2014 · 1 comment · Fixed by #49
Closed

Support id attribute variations? #47

lukehorvat opened this issue Jun 24, 2014 · 1 comment · Fixed by #49

Comments

@lukehorvat
Copy link
Contributor

As seen here, xml-crypto allows for an element's id attribute to be specified as "Id" or "ID". But I noticed here and here that passport-saml only supports "ID". Possible to make it support "Id" as well? (Not sure what the implications are, if any)
@ploer
Copy link
Contributor

ploer commented Jun 24, 2014

Good idea, care to put together a pull request? Thanks!

@lukehorvat lukehorvat mentioned this issue Jun 26, 2014
Merged
@ploer ploer closed this as completed in #49 Jun 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for node id attribute variations (e.g. "ID", "Id", etc.)
2 participants
@lukehorvat @ploer