You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wanted to start a discussion on this before going too deep into this. Currently, there is a difference in the schema used over in the standards-checklist repo and data structure in this proceedings repo as noted in this issue comment and also relates to #1. I believe this was part of why the back_migrate.js script was created - to make the submitted checklist version compatible with all the additional fields in the data structure mocked. Every time the proceedings page is deployed, all of the checklists are "migrated" with a new created version (hence the last review date == deployment date).
I would propose adding a few additional fields to the schema itself to retain the useful fields from the data structure without having to make changes to the checklist:
checklistVersion - this can be set in the checklist actions workflow
evaluationDate - this can also be set in the checklist actions workflow
evaluators - if set as issue assignees, then usernames and profiles can be fetched from the github api during the actions workflow as well
history - link to the commit history of a checklist
image - (optional) hardcoded for now to retain the brain image currently displayed, but eventually add to checklist?
toolVersion is another potentially useful one to include as part of the checklist itself, but would potentially be a field we would want to include on the checklist page, so leaving that out of this discussion for now.
With some further changes, the submitted checklists could be used directly without the need for migration. The main motivation for this is to have the schema and data structure in the two repos "synced", with the larger goal of also including a comments text-field to each checklist item, which would also require a change to both the schema and data structure anyways. This would also hopefully make future desire checklist changes easier to integrate as well.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Wanted to start a discussion on this before going too deep into this. Currently, there is a difference in the schema used over in the standards-checklist repo and data structure in this proceedings repo as noted in this issue comment and also relates to #1. I believe this was part of why the back_migrate.js script was created - to make the submitted checklist version compatible with all the additional fields in the data structure mocked. Every time the proceedings page is deployed, all of the checklists are "migrated" with a new created version (hence the last review date == deployment date).
I would propose adding a few additional fields to the schema itself to retain the useful fields from the data structure without having to make changes to the checklist:
checklistVersion
- this can be set in the checklist actions workflowevaluationDate
- this can also be set in the checklist actions workflowevaluators
- if set as issue assignees, then usernames and profiles can be fetched from the github api during the actions workflow as wellhistory
- link to the commit history of a checklistimage
- (optional) hardcoded for now to retain the brain image currently displayed, but eventually add to checklist?toolVersion
is another potentially useful one to include as part of the checklist itself, but would potentially be a field we would want to include on the checklist page, so leaving that out of this discussion for now.With some further changes, the submitted checklists could be used directly without the need for migration. The main motivation for this is to have the schema and data structure in the two repos "synced", with the larger goal of also including a comments text-field to each checklist item, which would also require a change to both the schema and data structure anyways. This would also hopefully make future desire checklist changes easier to integrate as well.
Beta Was this translation helpful? Give feedback.
All reactions