Skip to content

Commit 7b5d2ad

Browse files
authored
Merge pull request #356 from paulromano/allow-units-above-99
Allow units up to 999 to support processing of ENDF/B-VIII.1 light water TSL evaluation
2 parents 88fb846 + 4cde5d6 commit 7b5d2ad

File tree

7 files changed

+1146
-6
lines changed

7 files changed

+1146
-6
lines changed

ReleaseNotes.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
# Release Notes—NJOY2016
22
Given here are some release notes for NJOY2016. Each release is made through a formal [Pull Request](https://github.com/njoy/NJOY2016/pulls) made on GitHub. There are links in this document that point to each of those Pull Requests, where you can see in great details the changes that were made. Often the Pull Requests are made in response to an [issue](https://github.com/njoy/NJOY2016/issues). In such cases, links to those issues are also given.
33

4-
## NJOY2016.77
4+
## NJOY2016.78
5+
This update fixes the following issues:
6+
- Tape numbers are now allowed to go up to 999 instead of 99 previously. This change was made to accommodate processing of the light water evaluation in ENDF/B-VIII.1 that has 94 temperatures. Test 84 was added to detect this issue in the future.
7+
8+
## [NJOY2016.77](https://github.com/njoy/NJOY2016/pull/347)
59
This update fixes the following issues:
610
- Background cross section values for reactions other than total, elastic, fission and capture were not handled properly in the unresolved resonance region. The background for total, elastic, fission and capture is integrated into the unresolved resonance cross section values in the genunr subroutine. In the emerge subroutine, the background in the unresolved resonance region was therefore zeroed out for any resonance reaction. This has never been an issue but now we have LRF=7 evaluations that can define reactions other than total, elastic, fission and capture. Test 82 was added to detect this issue in the future.
711
- Increased the size of internal arrays in VIEWR.

src/util.f90

+4-4
Original file line numberDiff line numberDiff line change
@@ -179,14 +179,14 @@ subroutine openz(lun,new)
179179
integer::lun,new
180180
! internals
181181
integer::nun
182-
character::for*15,age*7,fn*6
182+
character::for*15,age*7,fn*7
183183
logical::there
184184

185185
nun=iabs(lun)
186186
if ((nun.ge.5.and.nun.le.7).or.nun.eq.0) return
187-
if (nun.gt.99) call error('openz','illegal unit number.',' ')
187+
if (nun.gt.999) call error('openz','illegal unit number.',' ')
188188
! construct file name
189-
write(fn,'(''tape'',i2)') nun
189+
write(fn,'(''tape'',i0)') nun
190190
! set format based on sign of unit number
191191
for='formatted'
192192
if (lun.lt.0) for='unformatted'
@@ -227,7 +227,7 @@ subroutine closz(lun)
227227

228228
nun=iabs(lun)
229229
if (nun.lt.10) return
230-
if (nun.gt.99) call error('closz','illegal unit number.',' ')
230+
if (nun.gt.999) call error('closz','illegal unit number.',' ')
231231
close(nun)
232232
return
233233
end subroutine closz

tests/84/CMakeLists.txt

+12
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
configure_file("${CMAKE_CURRENT_SOURCE_DIR}/input"
2+
"${CMAKE_CURRENT_BINARY_DIR}/input" COPYONLY )
3+
4+
configure_file("${CMAKE_CURRENT_SOURCE_DIR}/referenceTape100"
5+
"${CMAKE_CURRENT_BINARY_DIR}/referenceTape100" COPYONLY )
6+
7+
configure_file("${RESOURCES}/n-001_H_002-ENDF8.0.endf"
8+
"${CMAKE_CURRENT_BINARY_DIR}/tape20" COPYONLY )
9+
10+
add_test( NAME "Test84"
11+
COMMAND ${Python3_EXECUTABLE} "../execute.py"
12+
WORKING_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}" )

tests/84/input

+8
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
-- read tape20 and reconstruct
2+
reconr
3+
20 100
4+
'reconstructed data' /
5+
128 /
6+
0.001 /
7+
0 /
8+
stop

tests/84/referenceTape100

+1,115
Large diffs are not rendered by default.

tests/CMakeLists.txt

+1
Original file line numberDiff line numberDiff line change
@@ -85,3 +85,4 @@ add_subdirectory( "80" )
8585
add_subdirectory( "81" )
8686
add_subdirectory( "82" )
8787
add_subdirectory( "83" )
88+
add_subdirectory( "84" )

tests/execute.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ def writeDiff(diff_file, refLine, trialLine, lineNumber):
129129
exit(child.poll())
130130

131131
for reference_tape in reference_tapes:
132-
trial_tape = 'tape' + reference_tape[-2:]
132+
trial_tape = 'tape' + reference_tape[13:]
133133
if not filecmp.cmp(reference_tape, trial_tape):
134134
with open(reference_tape, 'r') as reference_file, \
135135
open(trial_tape, 'r') as trial_file, \

0 commit comments

Comments
 (0)