Skip to content

Commit 8b48d18

Browse files
Fix issue avoid-misusing-assert-true found at https://codereview.doctor (#306)
1 parent 25dbaed commit 8b48d18

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

spirit/category/admin/tests.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -201,20 +201,20 @@ def test_category_order(self):
201201
Category.objects.all().delete()
202202
cat1 = utils.create_category(title="1", sort=2)
203203
cat2 = utils.create_category(title="2", sort=1)
204-
self.assertTrue(list(Category.objects.all()), [cat1, cat2])
204+
self.assertEqual(list(Category.objects.all()), [cat1, cat2])
205205
form = CategoryForm(data=None)
206-
self.assertTrue(list(form.fields['parent'].queryset), [cat2, cat1])
206+
self.assertEqual(list(form.fields['parent'].queryset), [cat2, cat1])
207207
cat1.sort = 0
208208
cat1.save()
209-
self.assertTrue(list(Category.objects.all()), [cat1, cat2])
209+
self.assertEqual(list(Category.objects.all()), [cat1, cat2])
210210
form = CategoryForm(data=None)
211-
self.assertTrue(list(form.fields['parent'].queryset), [cat1, cat2])
211+
self.assertEqual(list(form.fields['parent'].queryset), [cat1, cat2])
212212

213213
@override_settings(ST_ORDERED_CATEGORIES=False)
214214
def test_category_order_by_title(self):
215215
Category.objects.all().delete()
216216
cat1 = utils.create_category(title="1", sort=2)
217217
cat2 = utils.create_category(title="2", sort=1)
218-
self.assertTrue(list(Category.objects.all()), [cat1, cat2])
218+
self.assertEqual(list(Category.objects.all()), [cat1, cat2])
219219
form = CategoryForm(data=None)
220-
self.assertTrue(list(form.fields['parent'].queryset), [cat1, cat2])
220+
self.assertEqual(list(form.fields['parent'].queryset), [cat1, cat2])

0 commit comments

Comments
 (0)