Fix two out of bounds accesses from qmk#13330. (qmk#13525)

firetech · nhongooi · commit 0854727cbfeb · 2021-12-05T08:46:40.000-05:00
Two occurrences of `MATRIX_ROWS` weren't properly changed to `ROWS_PER_HAND` in qmk#13330, causing a crash during boot on at least my Ergodox Infinity (including qmk#13481).
diff --git a/quantum/matrix.c b/quantum/matrix.c
@@ -149,7 +149,7 @@ static void unselect_row(uint8_t row) {
 }
 
 static void unselect_rows(void) {
-    for (uint8_t x = 0; x < MATRIX_ROWS; x++) {
+    for (uint8_t x = 0; x < ROWS_PER_HAND; x++) {
         unselect_row(x);
     }
 }
@@ -214,7 +214,7 @@ static void unselect_cols(void) {
 
 __attribute__((weak)) void matrix_init_pins(void) {
     unselect_cols();
-    for (uint8_t x = 0; x < MATRIX_ROWS; x++) {
+    for (uint8_t x = 0; x < ROWS_PER_HAND; x++) {
         if (row_pins[x] != NO_PIN) {
             setPinInputHigh_atomic(row_pins[x]);
         }

Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ static void unselect_row(uint8_t row) {`
`149`	`149`	`}`
`150`	`150`
`151`	`151`	`static void unselect_rows(void) {`
`152`		`- for (uint8_t x = 0; x < MATRIX_ROWS; x++) {`
	`152`	`+ for (uint8_t x = 0; x < ROWS_PER_HAND; x++) {`
`153`	`153`	`unselect_row(x);`
`154`	`154`	`}`
`155`	`155`	`}`
`@@ -214,7 +214,7 @@ static void unselect_cols(void) {`
`214`	`214`
`215`	`215`	`__attribute__((weak)) void matrix_init_pins(void) {`
`216`	`216`	`unselect_cols();`
`217`		`- for (uint8_t x = 0; x < MATRIX_ROWS; x++) {`
	`217`	`+ for (uint8_t x = 0; x < ROWS_PER_HAND; x++) {`
`218`	`218`	`if (row_pins[x] != NO_PIN) {`
`219`	`219`	`setPinInputHigh_atomic(row_pins[x]);`
`220`	`220`	`}`