Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate SCION to projects #590

Closed
eljamm opened this issue Mar 14, 2025 · 5 comments · Fixed by #715
Closed

Migrate SCION to projects #590

eljamm opened this issue Mar 14, 2025 · 5 comments · Fixed by #715
Assignees
@khabdrick
Labels
good first issue Good for newcomers

Comments

@eljamm
Copy link
Contributor

eljamm commented Mar 14, 2025 •
edited
Loading

The project needs to be moved from /projects-old into /projects and its artefacts tracked to match our project template.

Instructions

  1. Copy the templates/project/ template to the projects/ directory and re-name it to be the same as the project.
  2. Use the data from the projects-old/<project_name> entry, to fit the template.
  3. Remove any extra/unneeded things from the template that do not apply to the migrated project (e.g. a project has no services, ...).
  4. Check that the code is valid by running the test locally:
# For examples
$ nix build .#checks.x86_64-linux.projects/<project_name>/nixos/examples/<example_name>

# For tests
$ nix build .#checks.x86_64-linux.projects/<project_name>/nixos/tests/<test_name>
  1. Delete the projects-old/<project_name> directory and open a PR
@eljamm eljamm added the good first issue Good for newcomers label Mar 14, 2025
@eljamm eljamm added this to Nix@NGI Mar 14, 2025
@github-project-automation github-project-automation bot moved this to Needs refinement in Nix@NGI Mar 14, 2025
@eljamm eljamm mentioned this issue Mar 25, 2025
Open
@khabdrick
Copy link
Contributor

@eljamm I can do this

@khabdrick
Copy link
Contributor

Hello @eljamm
the scion old project doesn't have a test or example.
Am I supposed to develop that too? If yes, can you point me to a guide that can help me with the process?

@eljamm
Copy link
Contributor Author

eljamm commented Mar 31, 2025

Well, you're only supposed to move the things that are already there, but if you think it's easy to add an example and a test, then you could give that a try. You can take inspiration from other projects that do have them for what to put there. If you think it would take you much time then you don't need to bother with it.

@khabdrick
Copy link
Contributor

It's not as easy as I thought. I don't know where to start from to implement them.
I think I will just send the pr of the migration.

@eljamm
Copy link
Contributor Author

eljamm commented Apr 4, 2025

It's alright. You can send the PR and we can discuss things there.

@khabdrick khabdrick mentioned this issue Apr 4, 2025
Merged
@github-project-automation github-project-automation bot moved this from Needs refinement to Done in Nix@NGI Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khabdrick khabdrick

Labels
good first issue Good for newcomers
Projects
Nix@NGI
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

migrate scion default khabdrick/ngipkgs
2 participants
@khabdrick @eljamm