Skip to content

Commit f007400

Browse files
authored
Merge pull request #175 from LouisLeNezet/template_3.2.0
Update to 3.2.0 and add json support
2 parents 1ee25f9 + 7457f62 commit f007400

16 files changed

+54
-84
lines changed

.github/workflows/linting_comment.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
runs-on: ubuntu-latest
1212
steps:
1313
- name: Download lint results
14-
uses: dawidd6/action-download-artifact@80620a5d27ce0ae443b965134db88467fc607b43 # v7
14+
uses: dawidd6/action-download-artifact@20319c5641d495c8a52e688b7dc5fada6c3a9fbc # v8
1515
with:
1616
workflow: linting.yml
1717
workflow_conclusion: completed

.github/workflows/release-announcements.yml

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -27,39 +27,6 @@ jobs:
2727
2828
${{ steps.get_topics.outputs.topics }} #nfcore #openscience #nextflow #bioinformatics
2929
30-
send-tweet:
31-
runs-on: ubuntu-latest
32-
33-
steps:
34-
- uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5
35-
with:
36-
python-version: "3.10"
37-
- name: Install dependencies
38-
run: pip install tweepy==4.14.0
39-
- name: Send tweet
40-
shell: python
41-
run: |
42-
import os
43-
import tweepy
44-
45-
client = tweepy.Client(
46-
access_token=os.getenv("TWITTER_ACCESS_TOKEN"),
47-
access_token_secret=os.getenv("TWITTER_ACCESS_TOKEN_SECRET"),
48-
consumer_key=os.getenv("TWITTER_CONSUMER_KEY"),
49-
consumer_secret=os.getenv("TWITTER_CONSUMER_SECRET"),
50-
)
51-
tweet = os.getenv("TWEET")
52-
client.create_tweet(text=tweet)
53-
env:
54-
TWEET: |
55-
Pipeline release! ${{ github.repository }} v${{ github.event.release.tag_name }} - ${{ github.event.release.name }}!
56-
57-
Please see the changelog: ${{ github.event.release.html_url }}
58-
TWITTER_CONSUMER_KEY: ${{ secrets.TWITTER_CONSUMER_KEY }}
59-
TWITTER_CONSUMER_SECRET: ${{ secrets.TWITTER_CONSUMER_SECRET }}
60-
TWITTER_ACCESS_TOKEN: ${{ secrets.TWITTER_ACCESS_TOKEN }}
61-
TWITTER_ACCESS_TOKEN_SECRET: ${{ secrets.TWITTER_ACCESS_TOKEN_SECRET }}
62-
6330
bsky-post:
6431
runs-on: ubuntu-latest
6532
steps:

.nf-core.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
nf_core_version: 3.1.2
1+
nf_core_version: 3.2.0
22
repository_type: pipeline
33
template:
44
author: Louis Le Nezet, Anabella Trigila

.pre-commit-config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ repos:
77
88

99
- repo: https://github.com/editorconfig-checker/editorconfig-checker.python
10-
rev: "3.0.3"
10+
rev: "3.1.2"
1111
hooks:
1212
- id: editorconfig-checker
1313
alias: ec

CHANGELOG.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
77

88
### `Added`
99

10+
- [#175](https://github.com/nf-core/phaseimpute/pull/175) - Add support for all input files in `.json` or `.yaml` format.
11+
1012
### `Changed`
1113

1214
- [#166](https://github.com/nf-core/phaseimpute/pull/166) - Bump version to 1.1.0dev and update `CHANGELOG.md`.
1315
- [#170](https://github.com/nf-core/phaseimpute/pull/170) - Update TEMPLATE to nf-core tools version 3.1.2.
16+
- [#175](https://github.com/nf-core/phaseimpute/pull/175) - Update TEMPLATE to nf-core tools version 3.2.0. Move `CHRCHECK` functions to the workflow directory.
1417

1518
### `Fixed`
1619

@@ -79,7 +82,7 @@ Special thanks to [Matthias Hörtenhuber](https://github.com/mashehu), [Mazzalab
7982
- [#157](https://github.com/nf-core/phaseimpute/pull/157) - Add `chunk_model` as parameter for better control over `GLIMPSE2_CHUNK` and set window size in `GLIMPSE1_CHUNK` and `GLIMPSE2_chunk` to 4mb to reduce number of chunks (empirical).
8083
- [#160](https://github.com/nf-core/phaseimpute/pull/160) - Improve `CHANGELOG.md` and add details to `usage.md`
8184
- [#158](https://github.com/nf-core/phaseimpute/pull/158) - Remove frequency computation and phasing from full test to reduce cost and computational time.
82-
- [#164](https://github.com/nf-core/phaseimpute/pull/164) - Rename `BAM_REGION_SAMTOOLS` to `BAM_EXTRACT_REGION_SAMTOOLS`. Remove `GLIMPSE2_SPLITREFERENCE` as it is not used. Add more steps to `test_all` profile for more exhaustivity.
85+
- [#164](https://github.com/nf-core/phaseimpute/pull/164) - Rename `BAM_REGION_SAMTOOLS` to `BAM_EXTRACT_REGION_SAMTOOLS`. Remove `GLIMPSE2_SPLITREFERENCE` as it is not used. Add more steps to `test_all` profile for more exhaustiveness.
8386
- [#163](https://github.com/nf-core/phaseimpute/pull/163) - Improve configuration for demanding processes. Use Genome in a Bottle VCF benchmarking file for AWS full test. Moved from `glimpse1` to `glimpse2` for the full test profile.
8487
- [#165](https://github.com/nf-core/phaseimpute/pull/165) - Update metro map and add logo to the documentation.
8588

@@ -96,7 +99,7 @@ Special thanks to [Matthias Hörtenhuber](https://github.com/mashehu), [Mazzalab
9699
- [#161](https://github.com/nf-core/phaseimpute/pull/161) - Fix `VCF_SPLIT_BCFTOOLS` when only one sample present by updating `BCFTOOLS_PLUGINSPLIT` and adding `BCFTOOLS_QUERY` to get truth samples names for renaming the resulting files.
97100
- [#162](https://github.com/nf-core/phaseimpute/pull/162) - Fix `fai` usage when provided by `genomes` parameter.
98101
- [#164](https://github.com/nf-core/phaseimpute/pull/164) - Improve documentation writing
99-
- [#163](https://github.com/nf-core/phaseimpute/pull/163) - Fix MULTIQC samples names (add post-processing for clean up `FILTER_CHR_DWN`, `FILTER_CHR_INP`, `GAWK_ERROR_SPL`, `GAWK_RSQUARE_SPL`). Fix output panel `publisDir`. Fix java version to `17` in `ci.yml` due to new nextflow version.
102+
- [#163](https://github.com/nf-core/phaseimpute/pull/163) - Fix MULTIQC samples names (add post-processing for clean up `FILTER_CHR_DWN`, `FILTER_CHR_INP`, `GAWK_ERROR_SPL`, `GAWK_RSQUARE_SPL`). Fix output panel `publishDir`. Fix java version to `17` in `ci.yml` due to new nextflow version.
100103

101104
### `Dependencies`
102105

modules.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@
119119
},
120120
"multiqc": {
121121
"branch": "master",
122-
"git_sha": "cf17ca47590cc578dfb47db1c2a44ef86f89976d",
122+
"git_sha": "f0719ae309075ae4a291533883847c3f7c441dad",
123123
"installed_by": ["modules"]
124124
},
125125
"quilt/quilt": {

modules/nf-core/multiqc/environment.yml

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/multiqc/main.nf

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/multiqc/tests/main.nf.test.snap

Lines changed: 12 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

nextflow.config

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -276,14 +276,14 @@ env {
276276
}
277277

278278
// Set bash options
279-
process.shell = """\
280-
bash
281-
282-
set -e # Exit if a tool returns a non-zero status/exit code
283-
set -u # Treat unset variables and parameters as an error
284-
set -o pipefail # Returns the status of the last command to exit with a non-zero status or zero if all successfully execute
285-
set -C # No clobber - prevent output redirection from overwriting files.
286-
"""
279+
process.shell = [
280+
"bash",
281+
"-C", // No clobber - prevent output redirection from overwriting files.
282+
"-e", // Exit if a tool returns a non-zero status/exit code
283+
"-u", // Treat unset variables and parameters as an error
284+
"-o", // Returns the status of the last command to exit..
285+
"pipefail" // ..with a non-zero status or zero if all successfully execute
286+
]
287287

288288
// Disable process selector warnings by default. Use debug profile to enable warnings.
289289
nextflow.enable.configProcessNamesValidation = false

nextflow_schema.json

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"exists": true,
1919
"schema": "assets/schema_input.json",
2020
"mimetype": "text/csv",
21-
"pattern": "^\\S+\\.csv$",
21+
"pattern": "^\\S+\\.(csv|tsv|yaml|json)$",
2222
"description": "Path to comma-separated file containing information about the samples in the experiment.",
2323
"help_text": "You will need to create a design file with information about the samples in your experiment before running the pipeline. Use this parameter to specify its location. It has to be a comma-separated file with 3 columns, and a header row. See [usage docs](https://nf-co.re/phaseimpute/usage#samplesheet-input).",
2424
"fa_icon": "fas fa-file-csv"
@@ -28,7 +28,7 @@
2828
"description": "Region of the genome to use (optional: if no file given, the whole genome will be used). The file should be a comma-separated file with 3 columns, and a header row.",
2929
"schema": "assets/schema_input_region.json",
3030
"format": "file-path",
31-
"pattern": "^\\S+\\.csv$"
31+
"pattern": "^\\S+\\.(csv|tsv|yaml|json)$"
3232
},
3333
"outdir": {
3434
"type": "string",
@@ -94,7 +94,7 @@
9494
"genotype": {
9595
"type": "string",
9696
"description": "Genotype position to use to simulate the data",
97-
"pattern": "^\\S+\\.(csv|tsv|txt)$",
97+
"pattern": "^\\S+\\.(csv|tsv|yaml|json)$",
9898
"format": "file-path",
9999
"mimetype": "text/csv"
100100
}
@@ -112,7 +112,7 @@
112112
"fa_icon": "far fa-file-code",
113113
"format": "file-path",
114114
"schema": "assets/schema_input_panel.json",
115-
"pattern": "^\\S+\\.(csv|tsv|txt)$",
115+
"pattern": "^\\S+\\.(csv|tsv|yaml|json)$",
116116
"mimetype": "text/csv"
117117
},
118118
"phase": {
@@ -155,7 +155,15 @@
155155
"format": "file-path",
156156
"mimetype": "text/csv",
157157
"schema": "/assets/schema_chunks.json",
158-
"pattern": "^\\S+\\.csv$"
158+
"pattern": "^\\S+\\.(csv|tsv|yaml|json)$"
159+
},
160+
"posfile": {
161+
"type": "string",
162+
"description": "Path to comma-separated file containing tab-separated files describing the variable positions to be used for imputation. Refer to the documentation for the `--posfile` argument of STITCH for more information.",
163+
"format": "file-path",
164+
"schema": "assets/schema_posfile.json",
165+
"pattern": "^\\S+\\.(csv|tsv|yaml|json)$",
166+
"mimetype": "text/csv"
159167
},
160168
"seed": {
161169
"type": "integer",
@@ -177,7 +185,7 @@
177185
"exists": true,
178186
"schema": "assets/schema_input.json",
179187
"mimetype": "text/csv",
180-
"pattern": "^\\S+\\.csv$",
188+
"pattern": "^\\S+\\.(csv|tsv|yaml|json)$",
181189
"description": "Path to comma-separated file containing information about the samples truth files in the experiment.",
182190
"help_text": "You will need to create a design file with information about the samples in your experiment before running the pipeline. Use this parameter to specify its location. It has to be a comma-separated file with 3 columns, and a header row. See [usage docs](https://nf-co.re/phaseimpute/usage#samplesheet-input).",
183191
"fa_icon": "fas fa-file-csv"
@@ -441,14 +449,6 @@
441449
"description": "Arguments to customize STITCH run",
442450
"default": "",
443451
"properties": {
444-
"posfile": {
445-
"type": "string",
446-
"description": "Path to comma-separated file containing tab-separated files describing the variable positions to be used for imputation. Refer to the documentation for the `--posfile` argument of STITCH for more information.",
447-
"format": "file-path",
448-
"schema": "assets/schema_posfile.json",
449-
"pattern": "^\\S+\\.(csv|tsv|txt)$",
450-
"mimetype": "text/csv"
451-
},
452452
"k_val": {
453453
"type": "integer",
454454
"default": 2,

0 commit comments

Comments
 (0)