Skip to content

Overly long string size in input samplesheet causes samplesheet check to erroenously report missing header #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
microbemarsh opened this issue Feb 21, 2023 · 1 comment · Fixed by #227
Assignees
Labels
bug Something isn't working

Comments

@microbemarsh
Copy link

Description of the bug

When trying to run funcscan with more than 2 samples causes the pipeline to fail. slack channel thread

Command used and terminal output

nextflow run nf-core/funcscan --input funcscan_SLR25hyb.csv --outdir SLR25_hyb -profile docker --run_amp_screening --run_arg_screening --run_bgc_screening --amp_skip_amplify --arg_skip_deeparg --amp_skip_hmmsearch --bgc_skip_hmmsearch -r 1.0.0

######################################################################################

 Error executing process > 'NFCORE_FUNCSCAN:FUNCSCAN:INPUT_CHECK:SAMPLESHEET_CHECK (funcscan_SLR25hyb.csv)'

Caused by:
  Process `NFCORE_FUNCSCAN:FUNCSCAN:INPUT_CHECK:SAMPLESHEET_CHECK (funcscan_SLR25hyb.csv)` terminated with an error exit status (1)

Command executed:

  check_samplesheet.py \
      funcscan_SLR25hyb.csv \
      samplesheet.valid.csv
  
  cat <<-END_VERSIONS > versions.yml
  "NFCORE_FUNCSCAN:FUNCSCAN:INPUT_CHECK:SAMPLESHEET_CHECK":
      python: $(python --version | sed 's/Python //g')
  END_VERSIONS

Command exit status:
  1

Command output:
  (empty)

Command error:
  WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap.
  [CRITICAL] The given sample sheet does not appear to contain a header.

Relevant files

Link to 6 mags and csv file

System information

Nextflow version 22.10.6.5843
Local Server
Local
Docker
Ubuntu Linux
nf-core/funcscan -r 1.0.0

@microbemarsh microbemarsh added the bug Something isn't working label Feb 21, 2023
@jfy133 jfy133 changed the title >2 samples causes pipeline to fail Overly long string size in input samplesheet causes samplesheet check to erroenously report missing header Feb 22, 2023
@jfy133
Copy link
Member

jfy133 commented Feb 23, 2023

After a bit of experimenting (see end of the slack message above) it seems that if we reduce the number of new lines to check in the samplesheet_check.py down to 2 in the read_head() function, it then works.

@Midnighter believes he may have actually found a bug in python itself (:scream: ), and possibly suggests it might be easier to just use pandas for all of this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants