feat(file-versions): #53151 add VersionCreatedEvent event #53154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdovaz
requested review from
icewind1991,
nfebe and
skjnldsv
and removed request for
a team
Signed-off-by: Borja Domínguez Vázquez <[email protected]>
bdovaz
force-pushed
the
add-VersionCreatedEvent
branch
from
ce098ab to
4681bb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This event ensures the correct flow when creating custom metadata for a previously created version.
As I mentioned in that issue, that
+1in the catch makes everything very fragile:server/apps/files_versions/lib/Versions/LegacyVersionsBackend.php
Line 251 in c879bab
We could even refactor VersionAuthorListener if you think it's a good idea, so that it uses this event and decouples it from file events, which means that not all cases are covered (#53152) and it is more fragile.
TODO
Checklist