Skip to content

fix(NcButton): re-export types #6871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(NcButton): re-export types #6871

wants to merge 1 commit into from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented May 2, 2025

☑️ Resolves

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@ShGKme
fix(NcButton): re-export types
9636b43 
Signed-off-by: Grigorii K. Shartsev <[email protected]>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews feature: button labels May 2, 2025
@ShGKme ShGKme added this to the 9.0.0-rc.1 milestone May 2, 2025
@ShGKme ShGKme requested review from susnux and skjnldsv May 2, 2025 14:01
@ShGKme ShGKme self-assigned this May 2, 2025
susnux
susnux approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Affects much more components.
Either fix all manually or we deprecate using the main import in general and simply do not export types there so you only import

import type { ButtonVariant } from '@nextcloud/vue/components/NcButton'

@ShGKme
Copy link
Contributor Author

ShGKme commented May 2, 2025

Affects much more components

This is the only component with type export

@ShGKme
Copy link
Contributor Author

ShGKme commented May 2, 2025

@skjnldsv Does it work for you?
I am unsure this is the problem you had :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews bug Something isn't working feature: button
Projects
None yet
Milestone
9.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

Type export path is broken on vue 9.0.0-rc0
3 participants
@ShGKme @susnux @skjnldsv