Skip to content

[RFC] Proposal: remove or rework NcListItemIcon #6847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
susnux opened this issue Apr 27, 2025 · 2 comments
Open

[RFC] Proposal: remove or rework NcListItemIcon #6847

susnux opened this issue Apr 27, 2025 · 2 comments
Labels
discussion Need advices, opinions or ideas on this topic feature: list-item-icon Related to the list-item-icon component
Milestone
next major

Comments

@susnux
Copy link
Contributor

susnux commented Apr 27, 2025

It is mostly a non-interactive NcListItem (just without the anchor element) so it could contain custom interactive elements.
And its name is completely wrong anyway.

Options:

  • Remove if not needed
  • Rework to be reusable in NcListItem and only add the anchor there
@susnux susnux added this to the next major milestone Apr 27, 2025
@susnux susnux added discussion Need advices, opinions or ideas on this topic feature: list-item-icon Related to the list-item-icon component labels Apr 27, 2025
@skjnldsv
Copy link
Contributor

skjnldsv commented May 2, 2025

It's still used in:

  • Photos
  • Calendar
  • Mail
  • Contacts

@ShGKme
Copy link
Contributor

ShGKme commented May 2, 2025 •
edited
Loading

It's still used in:

We wan't change it without a major release :)
(Or without a forward compatibility)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion Need advices, opinions or ideas on this topic feature: list-item-icon Related to the list-item-icon component
Projects
None yet
Milestone
next major
Development

No branches or pull requests
3 participants
@susnux @skjnldsv @ShGKme