Skip to content

[NcAppSidebar] Close button not satisfies contrast for accessibility #6392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
susnux opened this issue Jan 17, 2025 · 0 comments · May be fixed by #6412
Open

[NcAppSidebar] Close button not satisfies contrast for accessibility #6392

susnux opened this issue Jan 17, 2025 · 0 comments · May be fixed by #6412
Labels
1. to develop Accepted and waiting to be taken care of accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: app-sidebar Related to the app-sidebar component

Comments

@susnux
Copy link
Contributor

susnux commented Jan 17, 2025 •
edited
Loading

Close button in app info panel is hard to see when screenshot is white or light coloured

Originally reported by @Justinzobel at nextcloud/server#50045

Bug description

When opening the app info sidebar e.g. https://nextcloud.domain/settings/apps/enabled/whiteboard it is not possible to see the circular x button to close the sidebar as it is low contrast.

Image

Steps to reproduce

  1. Install/enable whiteboard app
  2. Go to https://nextcloud.domain/settings/apps/enabled/whiteboard
  3. Look at screenshot and try to find the close button

Expected behavior

Close button has higher visibility.

Suggestion: The x button has an on-hover circular background. Make this background always present and increase the contrast between the X image and the circle image so it is clear to the user where to click to close that sidebar.
@susnux susnux added 1. to develop Accepted and waiting to be taken care of accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: app-sidebar Related to the app-sidebar component labels Jan 17, 2025
@susnux susnux mentioned this issue Jan 17, 2025
Closed
8 tasks
@ShGKme ShGKme changed the title [NcSidebar] Close button not satisfies contrast for accessibility [NcAppSidebar] Close button not satisfies contrast for accessibility Jan 17, 2025
@ShGKme ShGKme linked a pull request Jan 21, 2025 that will close this issue
Draft
3 tasks
@raimund-schluessler raimund-schluessler added this to the 8.23.0 milestone Jan 27, 2025
@Antreesy Antreesy modified the milestones: 8.23.0, 8.23.2 Feb 13, 2025
@susnux susnux modified the milestones: 8.23.2, 8.24.0 Feb 28, 2025
@ShGKme ShGKme modified the milestones: 8.24.0, 8.25.0 Apr 2, 2025
@susnux susnux removed this from the 8.25.0 milestone Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(NcAppSidebar): remove custom styles from close button nextcloud-libraries/nextcloud-vue
4 participants
@susnux @raimund-schluessler @ShGKme @Antreesy