Skip to content

feat(newrelic_cloud_aws_integrations): Add remaining aws polling integrations. #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2023

Conversation

Nandu-pns
Copy link
Contributor

@Nandu-pns Nandu-pns commented May 30, 2023

Description

Add other AWS polling integrations.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #2383 (64136c9) into main (925a317) will increase coverage by 0.22%.
The diff coverage is 23.23%.

@@            Coverage Diff             @@
##             main    #2383      +/-   ##
==========================================
+ Coverage   34.51%   34.74%   +0.22%     
==========================================
  Files          91       91              
  Lines       23355    24753    +1398     
==========================================
+ Hits         8061     8600     +539     
- Misses      15142    15976     +834     
- Partials      152      177      +25     
Impacted Files Coverage Δ
...elic/structures_newrelic_cloud_aws_integrations.go 0.00% <0.00%> (ø)
...wrelic/resource_newrelic_cloud_aws_integrations.go 89.72% <100.00%> (+4.94%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Nandu-pns Nandu-pns merged commit 8dd5d58 into main May 30, 2023
@Nandu-pns Nandu-pns deleted the pns/add_remaining_aws_integrations branch May 30, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants