Skip to content

feat(newrelic_cloud_azure_integrations): addition of the integration 'azureMonitor' #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2023

Conversation

pranav-new-relic
Copy link
Member

@pranav-new-relic pranav-new-relic commented Apr 24, 2023

Description

This PR addresses the addition of a new Azure Integration azureMonitor to the resource newrelic_cloud_azure_integrations.

Fixes # (issue)

#2254

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

@pranav-new-relic pranav-new-relic force-pushed the feat/azure-monitor branch 3 times, most recently from 20b4f5b to 84a8202 Compare May 2, 2023 04:28
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #2338 (c6677bc) into main (dc93cbd) will increase coverage by 0.03%.
The diff coverage is 40.57%.

❗ Current head c6677bc differs from pull request most recent head 6296b7d. Consider uploading reports for the commit 6296b7d to get more accurate results

@@            Coverage Diff             @@
##             main    #2338      +/-   ##
==========================================
+ Coverage   35.52%   35.55%   +0.03%     
==========================================
  Files          90       90              
  Lines       21332    21468     +136     
==========================================
+ Hits         7578     7634      +56     
- Misses      13602    13682      +80     
  Partials      152      152              
Impacted Files Coverage Δ
...source_newrelic_cloud_aws_govcloud_link_account.go 26.47% <0.00%> (ø)
...elic/resource_newrelic_cloud_azure_integrations.go 29.74% <41.17%> (+0.66%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A note for the reviewer: The changes in this file are not associated with the changes made to add the new Azure Integration; yet, they have been made as this datatype has been renamed ("C" made a capital letter in Govcloud) in client-go, as per the latest changes fetched via Tutone.

@pranav-new-relic pranav-new-relic marked this pull request as ready for review May 2, 2023 04:57
@pranav-new-relic pranav-new-relic force-pushed the feat/azure-monitor branch 2 times, most recently from 232e348 to 8d3d604 Compare May 3, 2023 07:26
@pranav-new-relic pranav-new-relic merged commit df7c5f5 into main May 3, 2023
@pranav-new-relic pranav-new-relic deleted the feat/azure-monitor branch May 3, 2023 14:42
usfdmiller pushed a commit to USFoods/terraform-provider-newrelic that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants