Skip to content

fix(newrelic_nrql_alert_condition): add default 'violation_time_limit_seconds' #2319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

pranav-new-relic
Copy link
Member

@pranav-new-relic pranav-new-relic commented Apr 6, 2023

Description

  • Addresses NR-97003
  • Adds a default 'violation_time_limit_seconds' of 259200 seconds to the newrelic_nrql_alert_condition resource
  • Fixes issues identified with re-applying terraform plan after the first terraform apply is executed, because a null violation_time_limit_seconds is defaulted to 259200 seconds (3 days), which is expected behaviour, as specified here.

Fixes #2245

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

@newrelic newrelic deleted a comment from codecov-commenter Apr 6, 2023
@pranav-new-relic pranav-new-relic marked this pull request as ready for review April 6, 2023 08:04
@pranav-new-relic pranav-new-relic merged commit bc62c35 into main Apr 6, 2023
@pranav-new-relic pranav-new-relic deleted the np/NR-97003 branch April 6, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants