Skip to content

fix(private_locations): returning the right err #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 10, 2023

Conversation

NSSPKrishna
Copy link
Member

Description

Please include a summary of the change and which issue is fixed (if relevant).

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Please delete options that are not relevant.

  • My commit message follows conventional commits
  • My code is formatted to Go standards
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

  • Step 1
  • Step 2
  • etc

@NSSPKrishna NSSPKrishna marked this pull request as ready for review December 27, 2022 03:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2023

Codecov Report

Merging #2177 (69a421d) into main (3440206) will increase coverage by 1.64%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2177      +/-   ##
==========================================
+ Coverage   35.45%   37.09%   +1.64%     
==========================================
  Files          84       84              
  Lines       20028    20031       +3     
==========================================
+ Hits         7101     7431     +330     
+ Misses      12794    12426     -368     
- Partials      133      174      +41     
Impacted Files Coverage Δ
...c/resource_newrelic_synthetics_private_location.go 32.93% <0.00%> (-0.61%) ⬇️
newrelic/resource_newrelic_workflow.go 93.84% <0.00%> (+8.69%) ⬆️
newrelic/structures_newrelic_workflow.go 63.17% <0.00%> (+9.71%) ⬆️
newrelic/helpers.go 79.74% <0.00%> (+10.12%) ⬆️
...c/structures_newrelic_notifications_destination.go 54.19% <0.00%> (+12.90%) ⬆️
...lic/resource_newrelic_notifications_destination.go 81.93% <0.00%> (+13.39%) ⬆️
...relic/structures_newrelic_notifications_channel.go 60.22% <0.00%> (+13.63%) ⬆️
newrelic/resource_helpers.go 15.27% <0.00%> (+13.88%) ⬆️
newrelic/provider.go 93.62% <0.00%> (+22.05%) ⬆️
...ewrelic/resource_newrelic_notifications_channel.go 69.44% <0.00%> (+23.33%) ⬆️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@NSSPKrishna NSSPKrishna requested a review from kidk January 10, 2023 09:34
@NSSPKrishna NSSPKrishna merged commit 873990f into main Jan 10, 2023
@NSSPKrishna NSSPKrishna deleted the pk/private-locations-import-err branch January 10, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants