Skip to content

Fix langchain versioned tests #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bizob2828 opened this issue May 20, 2024 · 1 comment · Fixed by #2202
Closed

Fix langchain versioned tests #2201

bizob2828 opened this issue May 20, 2024 · 1 comment · Fixed by #2202
Assignees
Labels

Comments

@bizob2828
Copy link
Member

Description

The langchain versioned tests are failing. Specifically around vectorstores

    # Subtest: should create vectorstore events for every similarity search call
        ok 1 - should create 3 events
        ok 2 - should create 2 langchain events
        1..2
    ok 1 - should create vectorstore events for every similarity search call # time=47.383ms
    
    # Subtest: should create span on successful vectorstore create
        ok 1 - expect truthy value
        ok 2 - segment "ROOT" should have child "Llm/vectorstore/Langchain/similaritySearch"
        1..2
    ok 2 - should create span on successful vectorstore create # time=15.991ms
    
    # Subtest: should increment tracking metric for each langchain vectorstore event
        not ok 1 - should be equal
          ---
          found: false
          wanted: true
          compare: ===
          at:
            line: 111
            column: 9
            file: vectorstore.tap.js
          stack: |
            vectorstore.tap.js:111:9
          source: |2
                  )
                  t.equal(metrics.callCount > 0, true)
            --------^
          
                  tx.end()
          ...
        
        1..1

That test is asserting the supportability metric of Supportability/Nodejs/ML/Langchain/${pkgVersion}. The issue is @langchain/core is getting tested but also the latest of @langchain/community. Since the version of @langchain/core differs the tracking metric version is different. The test needs to be updated to target the correct package version.

Expected Behavior

All tests pass

Steps to Reproduce

npm run versioned:internal langchain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
1 participant