feat: Added server span transaction naming fallback to the url.path (#2966)

Author: bizob2828

lib/otel/segments/server.js

@@ -62,7 +62,7 @@ function rpcSegment({ agent, otelSpan, transaction, rpcSystem }) {
 }
 
 function httpSegment({ agent, otelSpan, transaction, httpMethod }) {
-  const httpUrl = otelSpan.attributes[ATTR_HTTP_URL] || '/Unknown'
+  const httpUrl = otelSpan.attributes[ATTR_HTTP_URL] || '/unknown'
   transaction.nameState.setVerb(httpMethod)
   const requestUrl = url.parse(httpUrl, true)
   transaction.parsedUrl = requestUrl

lib/otel/span-processor.js

@@ -159,12 +159,18 @@ module.exports = class NrSpanProcessor {
       this.reconcileHttpAttributes({ segment, span, transaction })
     }
 
-    // End the corresponding transaction for the entry point server span.
-    // We do then when the span ends to ensure all data has been processed
-    // for the corresponding server span.
+    // If `http.route` was not emitted on server span, name the transaction from the path
+    // to avoid transactions being named `*`
+    if (transaction.parsedUrl) {
+      transaction.nameState.appendPathIfEmpty(transaction.parsedUrl?.path)
+    }
+    // Add the status code to transaction name
     if (transaction.statusCode) {
       transaction.finalizeNameFromUri(transaction.parsedUrl, transaction.statusCode)
     }
+    // End the corresponding transaction for the entry point server span.
+    // We do then when the span ends to ensure all data has been processed
+    // for the corresponding server span.
     transaction.end()
   }
 

test/unit/lib/otel/segment-synthesizer.test.js

@@ -232,15 +232,15 @@ test('should create base http server segment', (t) => {
   }
   const span = createBaseHttpSpan({ tracer, spanContext })
   const { segment, transaction } = synthesizer.synthesize(span)
-  assert.equal(segment.name, '/Unknown')
+  assert.equal(segment.name, '/unknown')
   assert.equal(segment.id, span.spanContext().spanId)
   assert.equal(segment.parentId, segment.root.id)
   assert.ok(transaction)
   assert.equal(transaction.traceId, span.spanContext().traceId)
-  assert.equal(transaction.url, '/Unknown')
+  assert.equal(transaction.url, '/unknown')
   assert.equal(transaction.baseSegment.name, segment.name)
   const attrs = transaction.trace.attributes.get(DESTINATIONS.TRANS_TRACE)
-  assert.equal(attrs['request.uri'], '/Unknown')
+  assert.equal(attrs['request.uri'], '/unknown')
   assert.ok(!attrs['request.method'])
   assert.ok(transaction)
 })

test/versioned/otel-bridge/span.test.js

@@ -443,7 +443,7 @@ test('server span(fallback) is bridged accordingly', (t, end) => {
 
     const duration = hrTimeToMilliseconds(span.duration)
     assert.equal(duration, segment.getDurationInMillis())
-    assert.equal(segment.name, 'WebTransaction/NormalizedUri/*')
+    assert.equal(segment.name, 'WebTransaction/WebFrameworkUri//unknown')
 
     const attrs = segment.getAttributes()
     assert.equal(attrs.host, expectedHost)
@@ -457,14 +457,14 @@ test('server span(fallback) is bridged accordingly', (t, end) => {
       'HttpDispatcher',
       'WebTransaction',
       'WebTransactionTotalTime',
-      'WebTransactionTotalTime/NormalizedUri/*',
+      'WebTransactionTotalTime/WebFrameworkUri//unknown',
       segment.name
     ]
     for (const expectedMetric of expectedMetrics) {
       assert.equal(unscopedMetrics[expectedMetric].callCount, 1, `${expectedMetric} has correct callCount`)
     }
     assert.equal(unscopedMetrics.Apdex.apdexT, 0.1)
-    assert.equal(unscopedMetrics['Apdex/NormalizedUri/*'].apdexT, 0.1)
+    assert.equal(unscopedMetrics['Apdex/WebFrameworkUri//unknown'].apdexT, 0.1)
 
     end()
   })