Skip to content

Commit 0a7b02d

Browse files
committed
add server.address field
1 parent 5c0086e commit 0a7b02d

File tree

64 files changed

+87
-10
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

64 files changed

+87
-10
lines changed

axiom/nr_span_event.c

+6
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,13 @@ void nr_span_event_set_datastore(nr_span_event_t* event,
322322
nro_set_hash_string(event->agent_attributes, "peer.address", new_value);
323323
break;
324324
case NR_SPAN_DATASTORE_PEER_HOSTNAME:
325+
/*
326+
* Both peer.hostname and server.address are expected to have the same
327+
* value. server.address is used to create the entity relationship map
328+
* and peer.hostname is maintained for backwards consistency.
329+
*/
325330
nro_set_hash_string(event->agent_attributes, "peer.hostname", new_value);
331+
nro_set_hash_string(event->agent_attributes, "server.address", new_value);
326332
break;
327333
}
328334
return;

tests/integration/jit/function/test_span_events_are_created_from_segments.php

+1
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@
9999
{
100100
"db.instance": "unknown",
101101
"peer.hostname": "unknown",
102+
"server.address": "unknown",
102103
"peer.address": "unknown:unknown"
103104
}
104105
]

tests/integration/jit/function/test_span_events_are_created_upon_caught_error.php

+1
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@
117117
{
118118
"db.instance": "unknown",
119119
"peer.hostname": "unknown",
120+
"server.address": "unknown",
120121
"peer.address": "unknown:unknown"
121122
}
122123
],

tests/integration/jit/function/test_span_events_are_created_upon_caught_error.php84.php

+1
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@
118118
{
119119
"db.instance": "unknown",
120120
"peer.hostname": "unknown",
121+
"server.address": "unknown",
121122
"peer.address": "unknown:unknown"
122123
}
123124
],

tests/integration/jit/function/test_span_events_are_created_upon_exit.php

+1
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@
7979
{
8080
"db.instance": "unknown",
8181
"peer.hostname": "unknown",
82+
"server.address": "unknown",
8283
"peer.address": "unknown:unknown"
8384
}
8485
],

tests/integration/jit/function/test_span_events_are_created_upon_uncaught_error.php

+1
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@
8484
{
8585
"db.instance": "unknown",
8686
"peer.hostname": "unknown",
87+
"server.address": "unknown",
8788
"peer.address": "unknown:unknown"
8889
}
8990
],

tests/integration/jit/function/test_span_events_are_created_upon_uncaught_error.php84.php

+1
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@
8585
{
8686
"db.instance": "unknown",
8787
"peer.hostname": "unknown",
88+
"server.address": "unknown",
8889
"peer.address": "unknown:unknown"
8990
}
9091
],

tests/integration/jit/function/test_span_events_are_created_upon_uncaught_handled_exception.php

+1
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@
120120
{
121121
"db.instance": "unknown",
122122
"peer.hostname": "unknown",
123+
"server.address": "unknown",
123124
"peer.address": "unknown:unknown"
124125
}
125126
],

tests/integration/jit/function/test_span_events_are_created_upon_uncaught_handled_exception.php84.php

+1
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,7 @@
121121
{
122122
"db.instance": "unknown",
123123
"peer.hostname": "unknown",
124+
"server.address": "unknown",
124125
"peer.address": "unknown:unknown"
125126
}
126127
],

tests/integration/jit/function/test_span_events_are_created_upon_uncaught_handled_exception_invalid_handler.php

+1
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@
131131
{
132132
"db.instance": "unknown",
133133
"peer.hostname": "unknown",
134+
"server.address": "unknown",
134135
"peer.address": "unknown:unknown"
135136
}
136137
],

tests/integration/jit/function/test_span_events_are_created_upon_uncaught_unhandled_exception.php

+1
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@
118118
{
119119
"db.instance": "unknown",
120120
"peer.hostname": "unknown",
121+
"server.address": "unknown",
121122
"peer.address": "unknown:unknown"
122123
}
123124
],

tests/integration/jit/function/test_span_events_error_collector_disabled.php

+1
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@
8484
{
8585
"db.instance": "unknown",
8686
"peer.hostname": "unknown",
87+
"server.address": "unknown",
8788
"peer.address": "unknown:unknown"
8889
}
8990
],

tests/integration/jit/function/test_span_events_exception_uncaught_nested.php

+1
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@
114114
{
115115
"db.instance": "unknown",
116116
"peer.hostname": "unknown",
117+
"server.address": "unknown",
117118
"peer.address": "unknown:unknown"
118119
}
119120
],

tests/integration/jit/tracing/test_span_events_are_created_from_segments.php

+1
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@
9999
{
100100
"db.instance": "unknown",
101101
"peer.hostname": "unknown",
102+
"server.address": "unknown",
102103
"peer.address": "unknown:unknown"
103104
}
104105
]

tests/integration/jit/tracing/test_span_events_are_created_upon_caught_error.php

+1
Original file line numberDiff line numberDiff line change
@@ -116,6 +116,7 @@
116116
{
117117
"db.instance": "unknown",
118118
"peer.hostname": "unknown",
119+
"server.address": "unknown",
119120
"peer.address": "unknown:unknown"
120121
}
121122
],

tests/integration/jit/tracing/test_span_events_are_created_upon_caught_error.php84.php

+1
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@
117117
{
118118
"db.instance": "unknown",
119119
"peer.hostname": "unknown",
120+
"server.address": "unknown",
120121
"peer.address": "unknown:unknown"
121122
}
122123
],

tests/integration/jit/tracing/test_span_events_are_created_upon_exit.php

+1
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@
7979
{
8080
"db.instance": "unknown",
8181
"peer.hostname": "unknown",
82+
"server.address": "unknown",
8283
"peer.address": "unknown:unknown"
8384
}
8485
],

tests/integration/jit/tracing/test_span_events_are_created_upon_uncaught_error.php

+1
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@
8484
{
8585
"db.instance": "unknown",
8686
"peer.hostname": "unknown",
87+
"server.address": "unknown",
8788
"peer.address": "unknown:unknown"
8889
}
8990
],

tests/integration/jit/tracing/test_span_events_are_created_upon_uncaught_error.php84.php

+1
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@
8585
{
8686
"db.instance": "unknown",
8787
"peer.hostname": "unknown",
88+
"server.address": "unknown",
8889
"peer.address": "unknown:unknown"
8990
}
9091
],

tests/integration/jit/tracing/test_span_events_are_created_upon_uncaught_handled_exception.php

+1
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@
117117
{
118118
"db.instance": "unknown",
119119
"peer.hostname": "unknown",
120+
"server.address": "unknown",
120121
"peer.address": "unknown:unknown"
121122
}
122123
],

tests/integration/jit/tracing/test_span_events_are_created_upon_uncaught_handled_exception.php84.php

+1
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@
118118
{
119119
"db.instance": "unknown",
120120
"peer.hostname": "unknown",
121+
"server.address": "unknown",
121122
"peer.address": "unknown:unknown"
122123
}
123124
],

tests/integration/jit/tracing/test_span_events_are_created_upon_uncaught_handled_exception_invalid_handler.php

+1
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@
126126
{
127127
"db.instance": "unknown",
128128
"peer.hostname": "unknown",
129+
"server.address": "unknown
129130
"peer.address": "unknown:unknown"
130131
}
131132
],

tests/integration/jit/tracing/test_span_events_are_created_upon_uncaught_unhandled_exception.php

+1
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@
118118
{
119119
"db.instance": "unknown",
120120
"peer.hostname": "unknown",
121+
"server.address": "unknown",
121122
"peer.address": "unknown:unknown"
122123
}
123124
],

tests/integration/jit/tracing/test_span_events_error_collector_disabled.php

+1
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@
8585
{
8686
"db.instance": "unknown",
8787
"peer.hostname": "unknown",
88+
"server.address": "unknown",
8889
"peer.address": "unknown:unknown"
8990
}
9091
],

tests/integration/jit/tracing/test_span_events_exception_uncaught_nested.php

+1
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@
115115
{
116116
"db.instance": "unknown",
117117
"peer.hostname": "unknown",
118+
"server.address": "unknown",
118119
"peer.address": "unknown:unknown"
119120
}
120121
],

tests/integration/opcache/disabled/test_span_events_are_created_from_segments.php

+1
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,7 @@
9595
{
9696
"db.instance": "unknown",
9797
"peer.hostname": "unknown",
98+
"server.address": "unknown",
9899
"peer.address": "unknown:unknown"
99100
}
100101
]

tests/integration/opcache/disabled/test_span_events_are_created_upon_caught_error.php

+1
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@
114114
{
115115
"db.instance": "unknown",
116116
"peer.hostname": "unknown",
117+
"server.address": "unknown",
117118
"peer.address": "unknown:unknown"
118119
}
119120
],

tests/integration/opcache/disabled/test_span_events_are_created_upon_caught_error.php84.php

+1
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@
114114
{
115115
"db.instance": "unknown",
116116
"peer.hostname": "unknown",
117+
"server.address": "unknown",
117118
"peer.address": "unknown:unknown"
118119
}
119120
],

tests/integration/opcache/disabled/test_span_events_are_created_upon_exit.php

+1
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@
7575
{
7676
"db.instance": "unknown",
7777
"peer.hostname": "unknown",
78+
"server.address": "unknown",
7879
"peer.address": "unknown:unknown"
7980
}
8081
],

tests/integration/opcache/disabled/test_span_events_are_created_upon_uncaught_error.php

+1
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@
8080
{
8181
"db.instance": "unknown",
8282
"peer.hostname": "unknown",
83+
"server.address": "unknown",
8384
"peer.address": "unknown:unknown"
8485
}
8586
],

tests/integration/opcache/disabled/test_span_events_are_created_upon_uncaught_error.php84.php

+1
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@
8181
{
8282
"db.instance": "unknown",
8383
"peer.hostname": "unknown",
84+
"server.address": "unknown",
8485
"peer.address": "unknown:unknown"
8586
}
8687
],

tests/integration/opcache/disabled/test_span_events_are_created_upon_uncaught_handled_exception.php

+1
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@
119119
{
120120
"db.instance": "unknown",
121121
"peer.hostname": "unknown",
122+
"server.address": "unknown",
122123
"peer.address": "unknown:unknown"
123124
}
124125
],

tests/integration/opcache/disabled/test_span_events_are_created_upon_uncaught_handled_exception.php7.php

+1
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@
8787
{
8888
"db.instance": "unknown",
8989
"peer.hostname": "unknown",
90+
"server.address": "unknown",
9091
"peer.address": "unknown:unknown"
9192
}
9293
],

tests/integration/opcache/disabled/test_span_events_are_created_upon_uncaught_handled_exception.php84.php

+1
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@
117117
{
118118
"db.instance": "unknown",
119119
"peer.hostname": "unknown",
120+
"server.address": "unknown",
120121
"peer.address": "unknown:unknown"
121122
}
122123
],

tests/integration/opcache/disabled/test_span_events_are_created_upon_uncaught_unhandled_exception.php

+1
Original file line numberDiff line numberDiff line change
@@ -114,6 +114,7 @@
114114
{
115115
"db.instance": "unknown",
116116
"peer.hostname": "unknown",
117+
"server.address": "unknown",
117118
"peer.address": "unknown:unknown"
118119
}
119120
],

tests/integration/opcache/disabled/test_span_events_error_collector_disabled.php

+1
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@
8181
{
8282
"db.instance": "unknown",
8383
"peer.hostname": "unknown",
84+
"server.address": "unknown",
8485
"peer.address": "unknown:unknown"
8586
}
8687
],

tests/integration/opcache/disabled/test_span_events_exception_uncaught_nested.php

+1
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@
110110
{
111111
"db.instance": "unknown",
112112
"peer.hostname": "unknown",
113+
"server.address": "unknown",
113114
"peer.address": "unknown:unknown"
114115
}
115116
],

tests/integration/pdo/mysql/base-class/test_instance_reporting_port.php

+1
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@
143143
{},
144144
{
145145
"peer.hostname": "ENV[MYSQL_HOST]",
146+
"server.address": "ENV[MYSQL_HOST]",
146147
"peer.address": "ENV[MYSQL_HOST]:ENV[MYSQL_PORT]",
147148
"db.instance": "ENV[MYSQL_DB]",
148149
"db.statement": "DROP TABLE ENV[DATASTORE_COLLECTION];"

tests/integration/pdo/mysql/base-class/test_instance_reporting_socket.php

+2
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@
118118
{},
119119
{
120120
"peer.hostname": "__HOST__",
121+
"server.address": "__HOST__",
121122
"peer.address": "__HOST__:ENV[MYSQL_SOCKET]",
122123
"db.instance": "ENV[MYSQL_DB]",
123124
"db.statement": "CREATE TABLE ENV[DATASTORE_COLLECTION] (id INT, description VARCHAR(?));"
@@ -142,6 +143,7 @@
142143
{},
143144
{
144145
"peer.hostname": "__HOST__",
146+
"server.address": "__HOST__",
145147
"peer.address": "__HOST__:ENV[MYSQL_SOCKET]",
146148
"db.instance": "ENV[MYSQL_DB]",
147149
"db.statement": "DROP TABLE ENV[DATASTORE_COLLECTION];"

tests/integration/pdo/mysql/constructor/test_instance_reporting_port.php

+2
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@
120120
{},
121121
{
122122
"peer.hostname": "ENV[MYSQL_HOST]",
123+
"server.address": "ENV[MYSQL_HOST]",
123124
"peer.address": "ENV[MYSQL_HOST]:ENV[MYSQL_PORT]",
124125
"db.instance": "ENV[MYSQL_DB]",
125126
"db.statement": "CREATE TABLE ENV[DATASTORE_COLLECTION] (id INT, description VARCHAR(?));"
@@ -144,6 +145,7 @@
144145
{},
145146
{
146147
"peer.hostname": "ENV[MYSQL_HOST]",
148+
"server.address": "ENV[MYSQL_HOST]",
147149
"peer.address": "ENV[MYSQL_HOST]:ENV[MYSQL_PORT]",
148150
"db.instance": "ENV[MYSQL_DB]",
149151
"db.statement": "DROP TABLE ENV[DATASTORE_COLLECTION];"

tests/integration/pdo/mysql/constructor/test_instance_reporting_socket.php

+2
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@
119119
{},
120120
{
121121
"peer.hostname": "__HOST__",
122+
"server.address": "__HOST__",
122123
"peer.address": "__HOST__:ENV[MYSQL_SOCKET]",
123124
"db.instance": "ENV[MYSQL_DB]",
124125
"db.statement": "CREATE TABLE ENV[DATASTORE_COLLECTION] (id INT, description VARCHAR(?));"
@@ -143,6 +144,7 @@
143144
{},
144145
{
145146
"peer.hostname": "__HOST__",
147+
"server.address": "__HOST__",
146148
"peer.address": "__HOST__:ENV[MYSQL_SOCKET]",
147149
"db.instance": "ENV[MYSQL_DB]",
148150
"db.statement": "DROP TABLE ENV[DATASTORE_COLLECTION];"

tests/integration/pdo/mysql/factory/test_instance_reporting_port.php

+2
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@
120120
{},
121121
{
122122
"peer.hostname": "ENV[MYSQL_HOST]",
123+
"server.address": "ENV[MYSQL_HOST]",
123124
"peer.address": "ENV[MYSQL_HOST]:ENV[MYSQL_PORT]",
124125
"db.instance": "ENV[MYSQL_DB]",
125126
"db.statement": "CREATE TABLE ENV[DATASTORE_COLLECTION] (id INT, description VARCHAR(?));"
@@ -144,6 +145,7 @@
144145
{},
145146
{
146147
"peer.hostname": "ENV[MYSQL_HOST]",
148+
"server.address": "ENV[MYSQL_HOST]",
147149
"peer.address": "ENV[MYSQL_HOST]:ENV[MYSQL_PORT]",
148150
"db.instance": "ENV[MYSQL_DB]",
149151
"db.statement": "DROP TABLE ENV[DATASTORE_COLLECTION];"

tests/integration/pdo/mysql/factory/test_instance_reporting_socket.php

+2
Original file line numberDiff line numberDiff line change
@@ -119,6 +119,7 @@
119119
{},
120120
{
121121
"peer.hostname": "__HOST__",
122+
"server.address": "__HOST__",
122123
"peer.address": "__HOST__:ENV[MYSQL_SOCKET]",
123124
"db.instance": "ENV[MYSQL_DB]",
124125
"db.statement": "CREATE TABLE ENV[DATASTORE_COLLECTION] (id INT, description VARCHAR(?));"
@@ -143,6 +144,7 @@
143144
{},
144145
{
145146
"peer.hostname": "__HOST__",
147+
"server.address": "__HOST__",
146148
"peer.address": "__HOST__:ENV[MYSQL_SOCKET]",
147149
"db.instance": "ENV[MYSQL_DB]",
148150
"db.statement": "DROP TABLE ENV[DATASTORE_COLLECTION];"

0 commit comments

Comments
 (0)